Add compose.host-ports.yml #4
Reference in New Issue
Block a user
No description provided.
Delete Branch "host-ports"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
based on conversation here: #1 (comment)
I have locally tested this PR and seems to be working
(in addition to running the similar PR #1 here for one month, which is working)
@ -13,2 +13,4 @@## Web client#COMPOSE_FILE="$COMPOSE_FILE:compose.mumbleweb.yml"## Host-port modeWhat are your thoughts on including a configurable port number in the config?
Upside: this would trivially allow multiple deployments on the same server, as long as each had a unique port.
Downside: might be confusing to the operator, especially since the port number would only be configurable in host-port mode.
I could see adding this, but maybe in a separate PR? could also in that PR think on if there is a way to also make it configurable in traefik mode somehow, at the same time.
But I think manually harcoding the port like this probably covers the majority of usecases
@ -53,0 +55,4 @@Instead of modifying the Traefik config,you can alternatively deploy Mumble with compose.host-ports.yml,and it will bind directly to the host server ports 64738 and 64739,I don't think 64739 is used anywhere.
lol you are correct.
I was somehow morphing this in my mind with lasuite-meet which does you multiple ports, and the fact that there were two entries (one for tcp and udp)
glad to have a second pair of eyes on it
@ -53,0 +58,4 @@and it will bind directly to the host server ports 64738 and 64739,bypassing Traefik.Note this doesn't work in multinode setups, but does work when deployed to a single server.I wonder if we should be more specific here?
In principle, there's nothing stopping a multinode setup from using host ports, as long as the operator locks deployment to specific nodes. But it will break in the typical swarm setup with interchangeable worker nodes.
Maybe something like:
What are your thoughts?
Your phrasing seems good to me. I changed it.
fixed the port error in the readme, and updated it to include your phrasing about multinode @amras
While resolving merge conflicts, I noticed we might want to document the new option in .env, too. I let myself add a short summary there.