coop-cloud/mumble
1
0
Fork 0
Code Issues 2 Pull Requests 1 Projects Releases Wiki Activity

Add healthcheck and backup labels #5

Manually merged
amras merged 3 commits from healthcheck-backups into main 2026-05-01 11:10:13 +00:00
Conversation 3 Commits 3 Files Changed 3 +16 -3
notplants commented 2026-04-28 17:18:27 +00:00
Owner
Copy Link

moving this into its own PR, as suggested here: #1 (comment)

tested the backup/restore flow locally and seems to be working (but a second test would always be welcome!)

moving this into its own PR, as suggested here: https://git.coopcloud.tech/coop-cloud/mumble/pulls/1#issuecomment-33149 tested the backup/restore flow locally and seems to be working (but a second test would always be welcome!)
notplants added 1 commit 2026-04-28 17:18:27 +00:00
add healthcheck and backup labels
Some checks failed
continuous-integration/drone/pr Build is failing
Details
e75aba093d
amras requested changes 2026-04-30 09:30:02 +00:00
compose.yml
@ -22,6 +28,11 @@ services:
- "traefik.udp.routers.${STACK_NAME}.service=${STACK_NAME}-udp-service"
- "traefik.udp.services.${STACK_NAME}-udp-service.loadbalancer.server.port=64738"
- "coop-cloud.${STACK_NAME}.version=0.1.0+v1.6.870-0"
- "backupbot.backup=${ENABLE_BACKUPS:-true}"
amras commented 2026-04-30 09:04:23 +00:00
Owner
Copy Link

ENABLE_BACKUPS is not specified in .env.sample - probably should be if it's used here.

Also, I'm unclear why we don't hardcode "backupbot.backup=true". What are the usecases where we want backups to be disabled?

ENABLE_BACKUPS is not specified in .env.sample - probably should be if it's used here. Also, I'm unclear why we don't hardcode "backupbot.backup=true". What are the usecases where we want backups to be disabled?
notplants commented 2026-04-30 14:37:10 +00:00
Author
Owner
Copy Link

I can't really think of a usecase either, but it is the pattern used in most co-op cloud recipes. Perhaps just to give the operator the possibility, maybe if they had some type of especially sensitive data in one application? Could be a good question for matrix. But it is the common pattern, for example in traefik and authentik.

I can't really think of a usecase either, but it is the pattern used in most co-op cloud recipes. Perhaps just to give the operator the possibility, maybe if they had some type of especially sensitive data in one application? Could be a good question for matrix. But it is the common pattern, for example in traefik and authentik.
compose.yml Outdated
@ -25,0 +32,4 @@
- 'backupbot.backup.pre-hook=sqlite3 /data/mumble-server.sqlite ".backup /data/backup.sqlite"'
- "backupbot.backup.post-hook=rm -f /data/backup.sqlite"
- "backupbot.backup.volumes.mumble_data.path=backup.sqlite"
- "backupbot.restore.post-hook=cp /data/backup.sqlite /data/mumble-server.sqlite"
amras commented 2026-04-30 09:14:44 +00:00
Owner
Copy Link

mv might be safer than cp here:

Say we perform backup->restore->backup, and sqlite3 fails on the last backup.
If we've used cp during restore, backupbot still sees the old backup and treats it as a new backup
If we've used mv, backupbot sees a missing file and (hopefully) reports the error.

`mv` might be safer than `cp` here: Say we perform backup->restore->backup, and sqlite3 fails on the last backup. If we've used `cp` during restore, backupbot still sees the old backup and treats it as a new backup If we've used `mv`, backupbot sees a missing file and (hopefully) reports the error.
notplants commented 2026-04-30 15:02:10 +00:00
Author
Owner
Copy Link

good call I think mv makes more sense here too

at the very least, the backup.sqlite is just sitting around taking up space and is not needed

good call I think `mv` makes more sense here too at the very least, the backup.sqlite is just sitting around taking up space and is not needed
amras commented 2026-04-30 10:30:09 +00:00
Owner
Copy Link

I think the README can also be updated to

Status: 3, stable

per https://docs.coopcloud.tech/abra/recipes/#status-overall-score since we're only missing integration testing following this PR.

I think the README can also be updated to > Status: 3, stable per https://docs.coopcloud.tech/abra/recipes/#status-overall-score since we're only missing integration testing following this PR.
notplants added 2 commits 2026-04-30 15:04:16 +00:00
explicitly add ENABLE_BACKUPS=true to env.sample ebbd2e57dc
update readme and use mv instead of cp in restore.post-hook
Some checks failed
continuous-integration/drone/pr Build is failing
Details
dde7691e53
notplants commented 2026-04-30 15:05:28 +00:00
Author
Owner
Copy Link

@amras incorporated your code review in the additional two commits. any other thoughts?

@amras incorporated your code review in the additional two commits. any other thoughts?
amras manually merged commit 608f5d805a into main 2026-05-01 11:10:13 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
amras
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 amras BornDeleuze cas coopcloud decentral1se fauno jjsfunhouse kawaiipunk knoflook moosemower notplants oxaliq p4u1 renovate-bot stevensting trav yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/mumble#5
No description provided.
Delete Branch "healthcheck-backups"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?