coop-cloud/nextcloud
coop-cloud
/
nextcloud
5
1
Fork 3
Code Issues 7 Pull Requests Releases Wiki Activity

WIP: Nextcloud and Nginx up version #30

Closed
javielico wants to merge 5 commits from javielico/nextcloud:main into main
pull from: javielico/nextcloud:main
merge into: coop-cloud:main
Conversation 6 Commits 5 Files Changed 3 +5 -9
javielico commented 2022-11-11 17:27:37 +00:00
Member
Copy Link

Two main changes:

  • Up version on Nextcloud and Nginx
  • Expanding .gitignore for VSCode, VIM, Linux, Mac.
Two main changes: * Up version on Nextcloud and Nginx * Expanding .gitignore for VSCode, VIM, Linux, Mac.
javielico added 2 commits 2022-11-11 17:27:38 +00:00
continuous-integration/drone/pr Build is failing Details
2ec6f21dd1
Up version on Nginx and Nextcloud to stable
javielico added 1 commit 2022-11-11 22:05:01 +00:00
continuous-integration/drone/pr Build is failing Details
8dcc2925ea
Version numbers back up
javielico commented 2022-11-11 22:05:13 +00:00
Author
Member
Copy Link

Added version numbers for most stable latest releases.

Added version numbers for most stable latest releases.
3wordchant requested changes 2022-11-12 03:10:56 +00:00
3wordchant left a comment
Owner
Copy Link

Looks fab, one last tiny suggested change!

Looks fab, one last tiny suggested change!
compose.yml Outdated
@ -84,3 +84,3 @@
cron:
image: nextcloud:24.0.6-fpm
image: nextcloud:stable-fpm
3wordchant commented 2022-11-12 03:10:44 +00:00
Owner
Copy Link

Would it be OK to switch this to 25.0.1 as well?

Would it be OK to switch this to `25.0.1` as well?
javielico added 1 commit 2022-11-12 12:53:39 +00:00
continuous-integration/drone/pr Build is failing Details
819378f3fb
Changes to cron version image
javielico requested review from 3wordchant 2022-11-12 12:53:55 +00:00
javielico commented 2022-11-12 12:55:17 +00:00
Author
Member
Copy Link

@3wordchant does it makes sense to use the alpine versions as well instead of the debian ones? Just purely due to the fact that they will use less resources.

@3wordchant does it makes sense to use the alpine versions as well instead of the debian ones? Just purely due to the fact that they will use less resources.
decentral1se reviewed 2022-11-12 16:32:00 +00:00
decentral1se left a comment
Owner
Copy Link

💯

💯
.gitignore
@ -1 +1,88 @@
/.envrc
decentral1se commented 2022-11-12 16:29:52 +00:00
Owner
Copy Link

I'd prefer to leave these out if possible? It seems pretty boilerplate-ish and most of these files won't end up in such a repository. Also, it raises the questions, why doesn't such a gitignore config feature in all the other recipes? You can add this stuff to your own personal global gitignore?

# ~/.gitconfig
[core]
  excludesfile = ~/.gitignore_global
I'd prefer to leave these out if possible? It seems pretty boilerplate-ish and most of these files won't end up in such a repository. Also, it raises the questions, why doesn't such a `gitignore` config feature in all the other recipes? You can add this stuff to your own personal global `gitignore`? ``` # ~/.gitconfig [core] excludesfile = ~/.gitignore_global ```
👍 2
3wordchant marked this conversation as resolved
compose.yml
@ -79,3 +79,3 @@
order: start-first
labels:
- "coop-cloud.${STACK_NAME}.version=2.1.4+24.0.6-fpm"
- "coop-cloud.${STACK_NAME}.version=2.1.6+25.0.1-fpm"
decentral1se commented 2022-11-12 16:31:40 +00:00
Owner
Copy Link

Is 24.x -> 25.x a major bump for the Nextcloud image? Might wanna check this once over?

Is `24.x` -> `25.x` a major bump for the Nextcloud image? Might wanna check this once over?
👍 2
javielico commented 2022-11-13 00:48:43 +00:00
Author
Member
Copy Link

Will do some tests from my end, not sure if you want to test anything at your end too before merging.

Will do some tests from my end, not sure if you want to test anything at your end too before merging.
3wordchant commented 2022-11-13 03:17:24 +00:00
Owner
Copy Link

I peeped the Nextcloud changelog and it doesn't look like anything major happened in those two releases. Personally happy for this to remain a "patch" version upgrade on the Co-op Cloud side as long as an upgrade or two goes smoothly.

I peeped [the Nextcloud changelog](https://nextcloud.com/changelog/) and it doesn't look like anything major happened in those two releases. Personally happy for this to remain a "patch" version upgrade on the Co-op Cloud side as long as an upgrade or two goes smoothly.
javielico commented 2022-11-13 16:27:37 +00:00
Author
Member
Copy Link

Perfect, I will perform a few tests this week coming and report back, it will be good if you can also test from your end and see if you're also happy with the result of the switchover to V25.

Perfect, I will perform a few tests this week coming and report back, it will be good if you can also test from your end and see if you're also happy with the result of the switchover to V25.
❤️ 2
decentral1se commented 2022-11-12 16:34:20 +00:00
Owner
Copy Link

@3wordchant does it makes sense to use the alpine versions as well instead of the debian ones? Just purely due to the fact that they will use less resources.

@javielico Some thoughts: that sounds like a nice idea. That might require some testing and changes in other files e.g. in the entrypoint or may have some unforseen consequences, so I would rather perhaps open up an issue to see if there is feedback on it. Several folks rely on the recipe as it is now. Opening up another PR with just those changes would be good too.

> @3wordchant does it makes sense to use the alpine versions as well instead of the debian ones? Just purely due to the fact that they will use less resources. @javielico Some thoughts: that sounds like a nice idea. That might require some testing and changes in other files e.g. in the entrypoint or may have some unforseen consequences, so I would rather perhaps open up an issue to see if there is feedback on it. Several folks rely on the recipe as it is now. Opening up another PR with just those changes would be good too.
👍 2
javielico commented 2022-11-13 00:49:32 +00:00
Author
Member
Copy Link

@3wordchant does it makes sense to use the alpine versions as well instead of the debian ones? Just purely due to the fact that they will use less resources.

@javielico Some thoughts: that sounds like a nice idea. That might require some testing and changes in other files e.g. in the entrypoint or may have some unforseen consequences, so I would rather perhaps open up an issue to see if there is feedback on it. Several folks rely on the recipe as it is now. Opening up another PR with just those changes would be good too.

Good point, I just thought I'd mention it thinking about the future not necessarily to change it now.

> > @3wordchant does it makes sense to use the alpine versions as well instead of the debian ones? Just purely due to the fact that they will use less resources. > > @javielico Some thoughts: that sounds like a nice idea. That might require some testing and changes in other files e.g. in the entrypoint or may have some unforseen consequences, so I would rather perhaps open up an issue to see if there is feedback on it. Several folks rely on the recipe as it is now. Opening up another PR with just those changes would be good too. Good point, I just thought I'd mention it thinking about the future not necessarily to change it now.
javielico added 1 commit 2022-11-13 00:51:34 +00:00
continuous-integration/drone/pr Build is failing Details
8b138eac19
Reverting back gitignore
javielico changed title from Nextcloud and Nginx up version to WIP: Nextcloud and Nginx up version 2022-11-13 00:52:04 +00:00
javielico commented 2022-11-19 15:19:25 +00:00
Author
Member
Copy Link

I suppose we can close this issue now that newest version has been merged, just to double check have you also updated the Nginx version @decentral1se?

I suppose we can close this issue now that newest version has been merged, just to double check have you also updated the Nginx version @decentral1se?
decentral1se commented 2022-11-21 10:12:11 +00:00
Owner
Copy Link

Ah @javielico apologies, I forgot this PR was open already... I didn't upgrade the Nginx version, so maybe this PR could be re-worked to do that? Or I could pick it up next time. As you like!

Ah @javielico apologies, I forgot this PR was open already... I didn't upgrade the Nginx version, so maybe this PR could be re-worked to do that? Or I could pick it up next time. As you like!
javielico closed this pull request 2022-11-30 09:34:36 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
3wordchant
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/nextcloud#30
No description provided.
Delete Branch "javielico/nextcloud:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?