coop-cloud/nextcloud
8
3
Fork 7
Code Issues 10 Pull Requests 1 Releases Wiki Activity

WIP: Nextcloud and Nginx up version #30

Closed
javielico wants to merge 5 commits from javielico/nextcloud:main into main
pull from: javielico/nextcloud:main
merge into: coop-cloud:main
Conversation 8 Commits 5 Files Changed 3 +5 -9
3 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.gitignore vendored
View File

@ -1 +1,2 @@
/.envrc
3wordchant marked this conversation as resolved
decentral1se commented 2022-11-12 16:29:52 +00:00
Review
Copy Link

I'd prefer to leave these out if possible? It seems pretty boilerplate-ish and most of these files won't end up in such a repository. Also, it raises the questions, why doesn't such a gitignore config feature in all the other recipes? You can add this stuff to your own personal global gitignore?

# ~/.gitconfig
[core]
  excludesfile = ~/.gitignore_global
I'd prefer to leave these out if possible? It seems pretty boilerplate-ish and most of these files won't end up in such a repository. Also, it raises the questions, why doesn't such a `gitignore` config feature in all the other recipes? You can add this stuff to your own personal global `gitignore`? ``` # ~/.gitconfig [core] excludesfile = ~/.gitignore_global ```
👍 2

5
.vscode/settings.json vendored
View File

@ -1,5 +0,0 @@
{
"shellcheck.customArgs": [
"--shell=bash"
]
}

8
compose.yml
View File

@ -1,7 +1,7 @@
version: "3.8"
services:
web:
image: nginx:1.23.1
image: nginx:1.22.1
configs:
- source: nginx_conf
target: /etc/nginx/nginx.conf
@ -35,7 +35,7 @@ services:
- "traefik.http.middlewares.${STACK_NAME}-redirect.headers.SSLHost=${DOMAIN}"
app:
image: nextcloud:24.0.6-fpm
image: nextcloud:25.0.1-fpm
depends_on:
- db
configs:
@ -78,12 +78,12 @@ services:
failure_action: rollback
order: start-first
labels:
- "coop-cloud.${STACK_NAME}.version=2.1.4+24.0.6-fpm"
- "coop-cloud.${STACK_NAME}.version=2.1.6+25.0.1-fpm"
decentral1se commented 2022-11-12 16:31:40 +00:00
Review
Copy Link

Is 24.x -> 25.x a major bump for the Nextcloud image? Might wanna check this once over?

Is `24.x` -> `25.x` a major bump for the Nextcloud image? Might wanna check this once over?
👍 2
javielico commented 2022-11-13 00:48:43 +00:00
Review
Copy Link

Will do some tests from my end, not sure if you want to test anything at your end too before merging.

Will do some tests from my end, not sure if you want to test anything at your end too before merging.
3wordchant commented 2022-11-13 03:17:24 +00:00
Review
Copy Link

I peeped the Nextcloud changelog and it doesn't look like anything major happened in those two releases. Personally happy for this to remain a "patch" version upgrade on the Co-op Cloud side as long as an upgrade or two goes smoothly.

I peeped [the Nextcloud changelog](https://nextcloud.com/changelog/) and it doesn't look like anything major happened in those two releases. Personally happy for this to remain a "patch" version upgrade on the Co-op Cloud side as long as an upgrade or two goes smoothly.
javielico commented 2022-11-13 16:27:37 +00:00
Review
Copy Link

Perfect, I will perform a few tests this week coming and report back, it will be good if you can also test from your end and see if you're also happy with the result of the switchover to V25.

Perfect, I will perform a few tests this week coming and report back, it will be good if you can also test from your end and see if you're also happy with the result of the switchover to V25.
❤️ 2
- "backupbot.backup=true"
- "backupbot.backup.path=/var/www/html/config/,/var/www/html/data/,/var/www/html/custom_apps/"
cron:
image: nextcloud:24.0.6-fpm
image: nextcloud:25.0.1-fpm
3wordchant commented 2022-11-12 03:10:44 +00:00
Outdated
Review
Copy Link

Would it be OK to switch this to 25.0.1 as well?

Would it be OK to switch this to `25.0.1` as well?
volumes:
- nextcloud:/var/www/html/
- nextapps:/var/www/html/custom_apps:cached