Recipe catalogue version ordering #427

New Issue

moritz · 2023-02-28T15:21:48Z

moritz commented

2023-02-28 15:21:48 +00:00

The recipe versions in the catalogue are not ordered according to the semver semantics. For example for the wekan recipe the version "0.12.0+v6.68" is placed between "0.1.1+v5.98" and "0.2.0+v6.05", therefore version "0.9.0+v6.34" is detected as latest version: d5a183e44d/recipes.json (L6633)

As the upgrade/deploy commands use the last version from the catalogue version order, the newest version is not detected.
Either the catalogue generation should return a correct semver version order or the function GetRecipeCatalogueVersions e4a89bcc4f/pkg/recipe/recipe.go (L1027) should do the ordering.

The recipe versions in the catalogue are not ordered according to the semver semantics. For example for the wekan recipe the version "0.12.0+v6.68" is placed between "0.1.1+v5.98" and "0.2.0+v6.05", therefore version "0.9.0+v6.34" is detected as latest version: https://git.coopcloud.tech/coop-cloud/recipes-catalogue-json/src/commit/d5a183e44dbb2a70abd9f7b87ac6e6956e7bbdc9/recipes.json#L6633 As the upgrade/deploy commands use the last version from the catalogue version order, the newest version is not detected. Either the catalogue generation should return a correct semver version order or the function `GetRecipeCatalogueVersions` https://git.coopcloud.tech/coop-cloud/abra/src/commit/e4a89bcc4f16e971acddf9e628e60a55cd7eee4e/pkg/recipe/recipe.go#L1027 should do the ordering.

moritz added the

bug

label 2023-02-28 15:21:48 +00:00

decentral1se commented

2023-03-05 10:36:07 +00:00

Oh yeh, that's a bad bug. Thanks for raising! Will have to check other places where the code assumes the catalogue is ordered. I'm not sure how things are done in e.g. the app ls -S listing of versions.

Oh yeh, that's a bad bug. Thanks for raising! Will have to check other places where the code assumes the catalogue is ordered. I'm not sure how things are done in e.g. the `app ls -S` listing of versions.

moritz referenced this issue from coop-cloud/abra

2023-04-14 14:57:26 +00:00

fix(version): semver version ordering #293

moritz referenced this issue from a commit

2023-04-26 06:38:19 +00:00

fix(version): semver version ordering (!293)

moritz closed this issue

2023-04-26 06:43:00 +00:00

decentral1se referenced this issue from a commit

2023-07-25 13:10:33 +00:00

fix: list downgrades/upgrades in correct order

Sign in to join this conversation.