toolshed/organising
toolshed/organising
8
1
Fork 0
Code Issues 120 Pull Requests Releases Activity

Recipe catalogue version ordering #427

New Issue
Closed
opened 2023-02-28 15:21:48 +00:00 by moritz · 1 comment
moritz commented 2023-02-28 15:21:48 +00:00
Member
Copy Link

The recipe versions in the catalogue are not ordered according to the semver semantics. For example for the wekan recipe the version "0.12.0+v6.68" is placed between "0.1.1+v5.98" and "0.2.0+v6.05", therefore version "0.9.0+v6.34" is detected as latest version: d5a183e44d/recipes.json (L6633)

As the upgrade/deploy commands use the last version from the catalogue version order, the newest version is not detected.
Either the catalogue generation should return a correct semver version order or the function GetRecipeCatalogueVersions e4a89bcc4f/pkg/recipe/recipe.go (L1027) should do the ordering.

The recipe versions in the catalogue are not ordered according to the semver semantics. For example for the wekan recipe the version "0.12.0+v6.68" is placed between "0.1.1+v5.98" and "0.2.0+v6.05", therefore version "0.9.0+v6.34" is detected as latest version: https://git.coopcloud.tech/coop-cloud/recipes-catalogue-json/src/commit/d5a183e44dbb2a70abd9f7b87ac6e6956e7bbdc9/recipes.json#L6633 As the upgrade/deploy commands use the last version from the catalogue version order, the newest version is not detected. Either the catalogue generation should return a correct semver version order or the function `GetRecipeCatalogueVersions` https://git.coopcloud.tech/coop-cloud/abra/src/commit/e4a89bcc4f16e971acddf9e628e60a55cd7eee4e/pkg/recipe/recipe.go#L1027 should do the ordering.
moritz added the
bug
 label 2023-02-28 15:21:48 +00:00
decentral1se commented 2023-03-05 10:36:07 +00:00
Owner
Copy Link

Oh yeh, that's a bad bug. Thanks for raising! Will have to check other places where the code assumes the catalogue is ordered. I'm not sure how things are done in e.g. the app ls -S listing of versions.

Oh yeh, that's a bad bug. Thanks for raising! Will have to check other places where the code assumes the catalogue is ordered. I'm not sure how things are done in e.g. the `app ls -S` listing of versions.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abra
Everything to do with abra
abra-gandi
Abra Gandi plugin
awaiting-feedback
Ping/pong on comms
backups
bug
Something is not working
build
Go build related issues
ci/cd
Getting the robots into the mix
community organising
Opening this thing up
contributing
Contributors stuff
coopcloud.tech
Our main website
democracy
Democratic decision making
design
Design thinking required
documentation
Let's write things together
duplicate
This issue or pull request already exists
enhancement
New feature
finance
Money things
funding
Anything related to grant funding
good first issue
Easy start with development
help wanted
Need some help
installer
Installation related issues
kadabra
performance
Performance related
proposal
Large change which requires feedback & decisin making
question
More information is needed
recipes.coopcloud.tech
Our recipes catalogue
security
Securing our shit
test
Unit or integration test suite
wontfix
This won't be fixed
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/organising#427
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?