fix(version): semver version ordering #293

2023-04-14T14:57:25Z

moritz commented

2023-04-14 14:57:25 +00:00

This fix sorts the recipe versions at the catalogue generation. This way also old abra clients will work correctly after a regeneration of the catalogue. The fix also sorts the versions that are received from the catalogue, so the catalogue entry order is agnostic to the version order, avoiding any implicit implementation assumptions.

Solves https://git.coopcloud.tech/coop-cloud/organising/issues/427 This fix sorts the recipe versions at the catalogue generation. This way also old abra clients will work correctly after a regeneration of the catalogue. The fix also sorts the versions that are received from the catalogue, so the catalogue entry order is agnostic to the version order, avoiding any implicit implementation assumptions.

moritz self-assigned this 2023-04-14 15:40:31 +00:00

decentral1se reviewed 2023-04-14 16:56:09 +00:00

decentral1se left a comment

Awesome, thanks for picking this up! Question: can we re-use tagcmp for the version comparison operations? I'd like to avoid an additional dependecy if possible.

Awesome, thanks for picking this up! Question: can we re-use [`tagcmp`](https://git.coopcloud.tech/coop-cloud/tagcmp) for the version comparison operations? I'd like to avoid an additional dependecy if possible.

moritz force-pushed fix_version_sort from 354389839c to c94cc9d38e

2023-04-25 13:01:39 +00:00

Compare

moritz added 1 commit 2023-04-25 14:13:04 +00:00

use tagcmp instead of semver

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/pr Build is passing

Details

b5182d80df

moritz commented

2023-04-25 14:19:42 +00:00

Awesome, thanks for picking this up! Question: can we re-use tagcmp for the version comparison operations? I'd like to avoid an additional dependecy if possible.

I replaced semver with tagcmp. But now I've seen that semver is pulled as indirect dependency anyway. I'm not sure which variant is better.

> Awesome, thanks for picking this up! Question: can we re-use [`tagcmp`](https://git.coopcloud.tech/coop-cloud/tagcmp) for the version comparison operations? I'd like to avoid an additional dependecy if possible. I replaced semver with tagcmp. But now I've seen that semver is pulled as indirect dependency anyway. I'm not sure which variant is better.

decentral1se commented

2023-04-25 15:20:23 +00:00

Aha @moritz righhhht, I forgot 😬 Yeh I'm happy with this as other places in the codebase uses tagcmp, so it's probably handy to keep using the same API surface. Merge away imho, thanks!

Aha @moritz righhhht, I forgot 😬 Yeh I'm happy with this as other places in the codebase uses `tagcmp`, so it's probably handy to keep using the same API surface. Merge away imho, thanks!

moritz merged commit 049da94629 into main

2023-04-26 06:38:17 +00:00

moritz referenced this issue from a commit

2023-04-26 06:38:19 +00:00

fix(version): semver version ordering (!293)

moritz deleted branch fix_version_sort

2023-04-26 06:38:22 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/abra#293