toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 27 Pull Requests 3 Packages Releases 40 Activity

fix(version): semver version ordering #293

Merged
moritz merged 3 commits from fix_version_sort into main 2023-04-26 06:38:18 +00:00
Conversation 3 Commits 3 Files Changed 3 +45 -1
moritz commented 2023-04-14 14:57:25 +00:00
Member
Copy Link

Solves coop-cloud/organising#427

This fix sorts the recipe versions at the catalogue generation. This way also old abra clients will work correctly after a regeneration of the catalogue. The fix also sorts the versions that are received from the catalogue, so the catalogue entry order is agnostic to the version order, avoiding any implicit implementation assumptions.

Solves https://git.coopcloud.tech/coop-cloud/organising/issues/427 This fix sorts the recipe versions at the catalogue generation. This way also old abra clients will work correctly after a regeneration of the catalogue. The fix also sorts the versions that are received from the catalogue, so the catalogue entry order is agnostic to the version order, avoiding any implicit implementation assumptions.
moritz self-assigned this 2023-04-14 15:40:31 +00:00
decentral1se reviewed 2023-04-14 16:56:09 +00:00
decentral1se left a comment
Owner
Copy Link

Awesome, thanks for picking this up! Question: can we re-use tagcmp for the version comparison operations? I'd like to avoid an additional dependecy if possible.

Awesome, thanks for picking this up! Question: can we re-use [`tagcmp`](https://git.coopcloud.tech/coop-cloud/tagcmp) for the version comparison operations? I'd like to avoid an additional dependecy if possible.
moritz force-pushed fix_version_sort from 354389839c to c94cc9d38e 2023-04-25 13:01:39 +00:00 Compare
moritz added 1 commit 2023-04-25 14:13:04 +00:00
use tagcmp instead of semver
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
b5182d80df
moritz commented 2023-04-25 14:19:42 +00:00
Author
Member
Copy Link

Awesome, thanks for picking this up! Question: can we re-use tagcmp for the version comparison operations? I'd like to avoid an additional dependecy if possible.

I replaced semver with tagcmp. But now I've seen that semver is pulled as indirect dependency anyway. I'm not sure which variant is better.

> Awesome, thanks for picking this up! Question: can we re-use [`tagcmp`](https://git.coopcloud.tech/coop-cloud/tagcmp) for the version comparison operations? I'd like to avoid an additional dependecy if possible. I replaced semver with tagcmp. But now I've seen that semver is pulled as indirect dependency anyway. I'm not sure which variant is better.
decentral1se commented 2023-04-25 15:20:23 +00:00
Owner
Copy Link

Aha @moritz righhhht, I forgot 😬 Yeh I'm happy with this as other places in the codebase uses tagcmp, so it's probably handy to keep using the same API surface. Merge away imho, thanks!

Aha @moritz righhhht, I forgot 😬 Yeh I'm happy with this as other places in the codebase uses `tagcmp`, so it's probably handy to keep using the same API surface. Merge away imho, thanks!
moritz merged commit 049da94629 into main 2023-04-26 06:38:17 +00:00
moritz deleted branch fix_version_sort 2023-04-26 06:38:22 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees moritz
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#293
No description provided.
Delete Branch "fix_version_sort"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?