toolshed/organising
toolshed/organising
8
1
Fork 0
Code Issues 120 Pull Requests Releases Activity

[Bug] Deploying old app versions doesn't work if compose-files don't match with latest main commit #617

New Issue
Closed
opened 2024-06-14 14:38:12 +00:00 by simon · 3 comments
simon commented 2024-06-14 14:38:12 +00:00
Member
Copy Link

Issue

Deploying old app versions doesn't work if compose-files don't match with latest main commit.

Steps to reproduce

With: https://git.coopcloud.tech/coop-cloud/nextcloud

  1. Delete compose.apps.yml
  2. Perform a local commit
  3. app deploy -n --debug --force --no-converge-checks <domain> 5.0.3+27.0.1-fpm
  4. FATA[0001] stat /home/sth/.abra/recipes/nextcloud/compose.apps.yml: no such file or directory

What's happening?

DEBU[0003] COMPOSE_FILE detected (compose.yml:compose.mariadb.yml:compose.smtp.yml:compose.apps.yml:compose.authentik.yml), loading compose.yml, compose.mariadb.yml, compose.smtp.yml, compose.apps.yml, compose.authentik.yml  caller="/home/user/abra/pkg/config/app.go:514 GetComposeFiles"
DEBU[0003] retrieved /home/user/.abra/recipes/nextcloud/compose.yml, /home/user/.abra/recipes/nextcloud/compose.mariadb.yml, /home/user/.abra/recipes/nextcloud/compose.smtp.yml, /home/user/.abra/recipes/nextcloud/compose.apps.yml, /home/user/.abra/recipes/nextcloud/compose.authentik.yml configs for nextcloud  caller="/home/user/abra/pkg/config/app.go:515 GetComposeFiles"

is beeing executed before this happens:

DEBU[0003] successfully checked nextcloud out to 5.0.3+27.0.1-fpm in /home/user/.abra/recipes/nextcloud  caller="/home/user/abra/pkg/recipe/recipe.go:353 EnsureVersion"

Afterwards this is executed:

DEBU[0003] COMPOSE_FILE detected (compose.yml:compose.mariadb.yml:compose.smtp.yml:compose.apps.yml:compose.authentik.yml), loading compose.yml, compose.mariadb.yml, compose.smtp.yml, compose.apps.yml, compose.authentik.yml  caller="/home/user/abra/pkg/config/app.go:514 GetComposeFiles"
DEBU[0003] retrieved /home/user/.abra/recipes/nextcloud/compose.yml, /home/user/.abra/recipes/nextcloud/compose.mariadb.yml, /home/user/.abra/recipes/nextcloud/compose.smtp.yml, /home/user/.abra/recipes/nextcloud/compose.apps.yml, /home/user/.abra/recipes/nextcloud/compose.authentik.yml configs for nextcloud  caller="/home/user/abra/pkg/config/app.go:515 GetComposeFiles"
DEBU[0003] retrieved /home/user/.abra/recipes/nextcloud/compose.yml for files.dev.local-it.cloud  caller="/home/user/abra/pkg/config/app.go:529 GetAppComposeConfig"

Possible solution?

Don't call GetComposeFiles before EnsureVersion

## Issue Deploying old app versions doesn't work if compose-files don't match with latest main commit. ## Steps to reproduce With: https://git.coopcloud.tech/coop-cloud/nextcloud 1. Delete compose.apps.yml 2. Perform a local commit 3. `app deploy -n --debug --force --no-converge-checks <domain> 5.0.3+27.0.1-fpm` 4. `FATA[0001] stat /home/sth/.abra/recipes/nextcloud/compose.apps.yml: no such file or directory` ## What's happening? ``` DEBU[0003] COMPOSE_FILE detected (compose.yml:compose.mariadb.yml:compose.smtp.yml:compose.apps.yml:compose.authentik.yml), loading compose.yml, compose.mariadb.yml, compose.smtp.yml, compose.apps.yml, compose.authentik.yml caller="/home/user/abra/pkg/config/app.go:514 GetComposeFiles" DEBU[0003] retrieved /home/user/.abra/recipes/nextcloud/compose.yml, /home/user/.abra/recipes/nextcloud/compose.mariadb.yml, /home/user/.abra/recipes/nextcloud/compose.smtp.yml, /home/user/.abra/recipes/nextcloud/compose.apps.yml, /home/user/.abra/recipes/nextcloud/compose.authentik.yml configs for nextcloud caller="/home/user/abra/pkg/config/app.go:515 GetComposeFiles" ``` is beeing executed before this happens: ``` DEBU[0003] successfully checked nextcloud out to 5.0.3+27.0.1-fpm in /home/user/.abra/recipes/nextcloud caller="/home/user/abra/pkg/recipe/recipe.go:353 EnsureVersion" ``` Afterwards this is executed: ``` DEBU[0003] COMPOSE_FILE detected (compose.yml:compose.mariadb.yml:compose.smtp.yml:compose.apps.yml:compose.authentik.yml), loading compose.yml, compose.mariadb.yml, compose.smtp.yml, compose.apps.yml, compose.authentik.yml caller="/home/user/abra/pkg/config/app.go:514 GetComposeFiles" DEBU[0003] retrieved /home/user/.abra/recipes/nextcloud/compose.yml, /home/user/.abra/recipes/nextcloud/compose.mariadb.yml, /home/user/.abra/recipes/nextcloud/compose.smtp.yml, /home/user/.abra/recipes/nextcloud/compose.apps.yml, /home/user/.abra/recipes/nextcloud/compose.authentik.yml configs for nextcloud caller="/home/user/abra/pkg/config/app.go:515 GetComposeFiles" DEBU[0003] retrieved /home/user/.abra/recipes/nextcloud/compose.yml for files.dev.local-it.cloud caller="/home/user/abra/pkg/config/app.go:529 GetAppComposeConfig" ``` ## Possible solution? Don't call GetComposeFiles before EnsureVersion
simon added the
bug
 label 2024-06-14 14:38:12 +00:00
simon added this to the (deleted) project 2024-06-14 14:38:13 +00:00
decentral1se commented 2024-06-16 18:43:41 +00:00
Owner
Copy Link

@simon I'm not sure I understand what you're goal was here. You make a local commit and then don't use --chaos but pass a version. Shouldn't abra check out 5.0.3+27.0.1-fpm and the files should all be there? If youre COMPOSE_FILES=... has a file that doesn't exist in the old version then I expect this error? Apologies, I think I'm missing something here.

Also, a note on process for using the "Critical fixes" project, please see R010: "The process for adding a ticket to the board requires getting confirmation from at least one other member of the federation." This is usually done in the Fedi/Tech chats on Matrix.

@simon I'm not sure I understand what you're goal was here. You make a local commit and then don't use `--chaos` but pass a version. Shouldn't `abra` check out `5.0.3+27.0.1-fpm` and the files should all be there? If youre `COMPOSE_FILES=...` has a file that doesn't exist in the old version then I expect this error? Apologies, I think I'm missing something here. Also, a note on process for using the "Critical fixes" project, please see [R010](https://docs.coopcloud.tech/federation/resolutions/passed/010/#details-budget-004): "The process for adding a ticket to the board requires getting confirmation from at least one other member of the federation." This is usually done in the Fedi/Tech chats on Matrix.
decentral1se added the
abra
awaiting-feedback
 labels 2024-06-16 18:44:10 +00:00
simon commented 2024-06-16 20:45:12 +00:00
Author
Member
Copy Link

@decentral1se My goal was to redeploy a nextcloud-deployment with a different configuration but the same version as previously deployed. But at the same time I was working on the nextcloud recipe due to a completely unrelated issue, including local changes I had to commit to provide a clean working environment for abra.

And you're right, abra should check out 5.0.3+27.0.1-fpm but it doesn't, as it maps the compose from the config with the latest main commit, doesn't find the compose.apps.yml anymore and crashed, before even beeing able to check out 5.0.3+27.0.1-fpm.

You should be able ro reproduce this as described above and abra should return an error on a missing compose.apps.yml

Expected behavior is that abra doesn't miss that compose.apps.yml as it clearly is available in 5.0.3+27.0.1-fpm

And thanks on the note to "Critical fixes". I think in the meantime, @3wordchant too voted for this.

@decentral1se My goal was to redeploy a nextcloud-deployment with a different configuration but the same version as previously deployed. But at the same time I was working on the nextcloud recipe due to a completely unrelated issue, including local changes I had to commit to provide a clean working environment for abra. And you're right, `abra` should check out `5.0.3+27.0.1-fpm` but it doesn't, as it maps the compose from the config with the latest `main` commit, doesn't find the `compose.apps.yml` anymore and crashed, before even beeing able to check out `5.0.3+27.0.1-fpm`. You should be able ro reproduce this as described above and abra should return an error on a missing compose.apps.yml Expected behavior is that abra doesn't miss that compose.apps.yml as it clearly is available in `5.0.3+27.0.1-fpm` And thanks on the note to "Critical fixes". I think in the meantime, @3wordchant too voted for this.
👍 1
decentral1se removed the
awaiting-feedback
 label 2024-06-19 17:06:06 +00:00
decentral1se commented 2024-06-19 18:36:53 +00:00
Owner
Copy Link

@simon lemme know what you think of coop-cloud/abra#411 🙏

@simon lemme know what you think of https://git.coopcloud.tech/coop-cloud/abra/pulls/411 🙏
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abra
Everything to do with abra
abra-gandi
Abra Gandi plugin
awaiting-feedback
Ping/pong on comms
backups
bug
Something is not working
build
Go build related issues
ci/cd
Getting the robots into the mix
community organising
Opening this thing up
contributing
Contributors stuff
coopcloud.tech
Our main website
democracy
Democratic decision making
design
Design thinking required
documentation
Let's write things together
duplicate
This issue or pull request already exists
enhancement
New feature
finance
Money things
funding
Anything related to grant funding
good first issue
Easy start with development
help wanted
Need some help
installer
Installation related issues
kadabra
performance
Performance related
proposal
Large change which requires feedback & decisin making
question
More information is needed
recipes.coopcloud.tech
Our recipes catalogue
security
Securing our shit
test
Unit or integration test suite
wontfix
This won't be fixed
No Label
abra
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/organising#617
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?