toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

fix: fix old app version deploy wrt. compose files #411

Merged
decentral1se merged 1 commits from versions-checkout-fix into main 2024-06-21 14:26:56 +00:00
Conversation 3 Commits 1 Files Changed 3 +57 -9
decentral1se commented 2024-06-19 18:32:57 +00:00
Owner
Copy Link

See coop-cloud/organising#617

Manually ran the test suite on app_deploy.bats and things seem to be in order!

See https://git.coopcloud.tech/coop-cloud/organising/issues/617 Manually ran the test suite on `app_deploy.bats` and things seem to be in order!
decentral1se requested review from simon 2024-06-19 18:33:05 +00:00
p4u1 reviewed 2024-06-20 21:22:44 +00:00
tests/integration/app_deploy.bats Outdated
@ -373,0 +397,4 @@
assert_success
refute_output --partial 'no such file or directory'
_undeploy_app
p4u1 commented 2024-06-20 21:22:44 +00:00
Member
Copy Link

Would be nice to get the cleanup simplified in the future....
Something like _reset_all

Would be nice to get the cleanup simplified in the future.... Something like `_reset_all`
👍 1
decentral1se commented 2024-06-21 14:13:56 +00:00
Author
Owner
Copy Link

Yeh this remains quite an elusive thing... a cleaning up of order of execution, cleanup, etc.

I will make a ticket 🙃

Yeh this remains quite an elusive thing... a cleaning up of order of execution, cleanup, etc. I will make a ticket 🙃
👍 1
decentral1se marked this conversation as resolved
p4u1 commented 2024-06-20 21:28:24 +00:00
Member
Copy Link

Can we now remove the same block starting on line 131?

Can we now remove the same block starting on line 131?
decentral1se commented 2024-06-21 14:14:29 +00:00
Author
Owner
Copy Link

Can we now remove the same block starting on line 131?

Good shout, I can just move that block up instead of duplicating it 😌 Thanks!

> Can we now remove the same block starting on line 131? Good shout, I can just move that block up instead of duplicating it 😌 Thanks!
👍 1
decentral1se force-pushed versions-checkout-fix from cfbafd2613 to 91ea2c01a5 2024-06-21 14:26:27 +00:00 Compare
decentral1se merged commit 91ea2c01a5 into main 2024-06-21 14:26:56 +00:00
decentral1se deleted branch versions-checkout-fix 2024-06-21 14:26:56 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
simon
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#411
No description provided.
Delete Branch "versions-checkout-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?