coop-cloud/outline
coop-cloud
/
outline
generated from coop-cloud/example
1
0
Fork 3
Code Issues 7 Pull Requests Projects Releases Wiki Activity

add-local-storage-support #18

Closed
simon wants to merge 0 commits from simon/outline:add-local-storage-support into main
pull from: simon/outline:add-local-storage-support
merge into: coop-cloud:main
Conversation 2 Commits - Files Changed -
simon commented 2023-12-14 13:23:56 +00:00
Member
Copy Link

Added support for local storage and moved aws s3 config into a separate compose.yml

Local Storage configuration works fine for me. However I'm unable to test if the s3 config still works since I don't run such a system.

Added support for local storage and moved aws s3 config into a separate compose.yml Local Storage configuration works fine for me. However I'm unable to test if the s3 config still works since I don't run such a system.
simon added 2 commits 2023-12-14 13:23:57 +00:00
decentral1se reviewed 2023-12-14 21:01:57 +00:00
decentral1se left a comment
Owner
Copy Link

Thanks @simon, this looks legit to me! Hopefully some folks who co-maintain this recipe can also take a review pass. If nobody is turning up, maybe try the Matrix channels to ask for a review. Can merge if nobody has time and you have confidence in it also.

Thanks @simon, this looks legit to me! Hopefully some folks who co-maintain this recipe can also take a review pass. If nobody is turning up, maybe try the Matrix channels to ask for a review. Can merge if nobody has time and you have confidence in it also.
❤️ 1
simon added 1 commit 2023-12-17 14:51:37 +00:00
simon requested review from iexos 2023-12-18 11:59:48 +00:00
simon commented 2023-12-18 12:01:12 +00:00
Author
Member
Copy Link

Thanks @decentral1se!
@iexos also agreed to do a review on this :)

Thanks @decentral1se! @iexos also agreed to do a review on this :)
iexos commented 2023-12-19 17:52:06 +00:00
Member
Copy Link

Thank you @simon !
Just needed to update the entrypoint script version in abra.sh to make it work. Merged with this fix.

Thank you @simon ! Just needed to update the entrypoint script version in `abra.sh` to make it work. Merged with this fix.
iexos closed this pull request 2023-12-19 17:52:06 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
iexos
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/outline#18
No description provided.
Delete Branch "simon/outline:add-local-storage-support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?