<!--
Thank you for doing recipe maintenance work!
Please mark all checklist items which are relevant for your changes.
Please remove the checklist items which are not relevant for your changes.
Feel free to remove this comment.
-->
* [x] I have deployed and tested my changes
* [ ] I have [updated relevant versions in `abra.sh`](https://docs.coopcloud.tech/maintainers/upgrade/#updating-versions-in-the-abrash)
* [x] I have made my environment variable changes [backwards compatible](https://docs.coopcloud.tech/maintainers/upgrade/#backwards-compatible-environment-variable-changes)
* [ ] I have added a [release note entry](https://docs.coopcloud.tech/maintainers/upgrade/#creating-new-release-notes)
Will it be possible to reuse the access log implementation from here in the crowd sec PR? @devydave
The crowd sec PR also adds access logs. https://git.coopcloud.tech/coop-cloud/traefik/pulls/122
Will it be possible to reuse the access log implementation from here in the crowd sec PR? @devydave
mmm [according to this, crowdsec should be able to parse json logs](https://github.com/crowdsecurity/hub/blob/master/parsers/s01-parse/crowdsecurity/traefik-logs.yaml#L25) so we could merge both implementations. maybe make crowdsec depend on access-log?
that should work I can adjust it, when this is merged. One thing I am unsure should we add docs for new users that they need to include COMPOSE_FILE="$COMPOSE_FILE:compose.access-log.yml" or should I set ACCESS_LOG_ENABLED: "true" in the crowdsec compose file.
> mmm [according to this, crowdsec should be able to parse json logs](https://github.com/crowdsecurity/hub/blob/master/parsers/s01-parse/crowdsecurity/traefik-logs.yaml#L25) so we could merge both implementations. maybe make crowdsec depend on access-log?
that should work I can adjust it, when this is merged. One thing I am unsure should we add docs for new users that they need to include COMPOSE_FILE="$COMPOSE_FILE:compose.access-log.yml" or should I set ACCESS_LOG_ENABLED: "true" in the crowdsec compose file.
remind users to enable access logs and possibly fail if they don't
disable crowdsec's access log acquisition if access log is disabled (afaict it's optional, right? is it a privacy issue too? as in are they being sent to crowdsec servers?)
add the ACCESS_LOG_ENABLED on compose.crowdsec.yml without adding the volume, so if you want persistent storage you need to enable compose.access-log.yml yourself
chain the two compose files COMPOSE_FILE="$COMPOSE_FILE:compose.access-log.yml:compose.crowdsec.yml so enabling crowdsec also enables access-log without further reading
@devydave i'm not sure what is best:
* remind users to enable access logs and possibly fail if they don't
* disable crowdsec's access log acquisition if access log is disabled (afaict it's optional, right? is it a privacy issue too? as in are they being sent to crowdsec servers?)
* add the `ACCESS_LOG_ENABLED` on `compose.crowdsec.yml` without adding the volume, so if you want persistent storage you need to enable `compose.access-log.yml` yourself
* chain the two compose files `COMPOSE_FILE="$COMPOSE_FILE:compose.access-log.yml:compose.crowdsec.yml` so enabling crowdsec also enables access-log without further reading
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
abra.shThe crowd sec PR also adds access logs. #122
Will it be possible to reuse the access log implementation from here in the crowd sec PR? @devydave
mmm according to this, crowdsec should be able to parse json logs so we could merge both implementations. maybe make crowdsec depend on access-log?
that should work I can adjust it, when this is merged. One thing I am unsure should we add docs for new users that they need to include COMPOSE_FILE="$COMPOSE_FILE:compose.access-log.yml" or should I set ACCESS_LOG_ENABLED: "true" in the crowdsec compose file.
@devydave i'm not sure what is best:
ACCESS_LOG_ENABLEDoncompose.crowdsec.ymlwithout adding the volume, so if you want persistent storage you need to enablecompose.access-log.ymlyourselfCOMPOSE_FILE="$COMPOSE_FILE:compose.access-log.yml:compose.crowdsec.ymlso enabling crowdsec also enables access-log without further reading@@ -227,1 +227,4 @@#ONION_ENABLED=1## Keep access logs on a volume.# You'll need to setup rotation yourself and send the USR1 signal toCan you give an example of how to setup the log rotation?
Is this ready for final review also @fauno?
yes :)