COMPOSE_FILE=$COMPOSE_FILE:`, to combine 'em easier #27

3wordchant · 2021-08-07T15:06:36Z

3wordchant commented

2021-08-07 15:06:36 +00:00

This should make it easier to use multiple additional compose files, because now you just need to uncomment the relevant COMPOSE_FILE lines, instead of having to manually write out which combination you want in a single line.

3wordchant added 2 commits 2021-08-07 15:06:37 +00:00

8bcd8f054e Add missing Mumble vars to .env.sample

continuous-integration/drone/push Build is failing Details

continuous-integration/drone/pr Build is failing Details

e856591c97 `COMPOSE_FILE=$COMPOSE_FILE:`, to combine 'em easier

Thanks, @mirsal

3wordchant requested review from mirsal 2021-08-07 15:06:52 +00:00

mirsal requested changes 2021-08-07 17:18:54 +00:00

mirsal left a comment

Hey,

It's missing initialization of the COMPOSE_FILE variable (see inline comment), otherwise lgtm

(maybe also move the comments and cosmetic changes to their own commit)

cheers <3

Hey, It's missing initialization of the `COMPOSE_FILE` variable (see inline comment), otherwise lgtm (maybe also move the comments and cosmetic changes to their own commit) cheers <3

.env.sample

						
				@ -11,0 +13,4 @@

				#####################################################################

				## Host-mode networking

				#COMPOSE_FILE="$COMPOSE_FILE:compose.host.yml"

mirsal commented

2021-08-07 17:07:45 +00:00

I see no earlier reference to COMPOSE_FILE, I believe it should be set prior to using it, like so:

COMPOSE_FILE=compose.yml

abra sets the environment using the shell, so that environment variable would not be initialized otherwise.

I see no earlier reference to `COMPOSE_FILE`, I believe it should be set prior to using it, like so: ``` COMPOSE_FILE=compose.yml ``` abra sets the environment using the shell, so that environment variable would not be initialized otherwise.

mirsal marked this conversation as resolved

3wordchant added 1 commit 2021-08-07 17:50:46 +00:00