coop-cloud/traefik
6
2
Fork 19
Code Issues 14 Pull Requests 7 Releases Wiki Activity

COMPOSE_FILE=$COMPOSE_FILE:`, to combine 'em easier #27

Merged
3wordchant merged 3 commits from rejig-compose-vars into master 2021-08-07 17:55:06 +00:00
Conversation 3 Commits 3 Files Changed 1
+51 -26
3wordchant commented 2021-08-07 15:06:36 +00:00
Owner
Copy Link
Copy Source

This should make it easier to use multiple additional compose files, because now you just need to uncomment the relevant COMPOSE_FILE lines, instead of having to manually write out which combination you want in a single line.

This should make it easier to use multiple additional compose files, because now you just need to uncomment the relevant COMPOSE_FILE lines, instead of having to manually write out which combination you want in a single line.
3wordchant added 2 commits 2021-08-07 15:06:37 +00:00
Add missing Mumble vars to .env.sample 8bcd8f054e
COMPOSE_FILE=$COMPOSE_FILE:, to combine 'em easier
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
e856591c97 
Thanks, @mirsal
3wordchant requested review from mirsal 2021-08-07 15:06:52 +00:00
mirsal requested changes 2021-08-07 17:18:54 +00:00
mirsal left a comment
Member
Copy Link
Copy Source

Hey,

It's missing initialization of the COMPOSE_FILE variable (see inline comment), otherwise lgtm

(maybe also move the comments and cosmetic changes to their own commit)

cheers <3

Hey, It's missing initialization of the `COMPOSE_FILE` variable (see inline comment), otherwise lgtm (maybe also move the comments and cosmetic changes to their own commit) cheers <3
.env.sample
@@ -11,0 +13,4 @@
#####################################################################
## Host-mode networking
#COMPOSE_FILE="$COMPOSE_FILE:compose.host.yml"
mirsal commented 2021-08-07 17:07:45 +00:00
Member
Copy Link
Copy Source

I see no earlier reference to COMPOSE_FILE, I believe it should be set prior to using it, like so:

COMPOSE_FILE=compose.yml

abra sets the environment using the shell, so that environment variable would not be initialized otherwise.

I see no earlier reference to `COMPOSE_FILE`, I believe it should be set prior to using it, like so: ``` COMPOSE_FILE=compose.yml ``` abra sets the environment using the shell, so that environment variable would not be initialized otherwise.
mirsal marked this conversation as resolved
3wordchant added 1 commit 2021-08-07 17:50:46 +00:00
Add default COMPOSE_FILE
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
baba7ff87d
3wordchant commented 2021-08-07 17:53:40 +00:00
Author
Owner
Copy Link
Copy Source

Fixed, thank you! 🙏

Fixed, thank you! 🙏
❤️ 1
3wordchant merged commit 9e123afb07 into master 2021-08-07 17:55:06 +00:00
mirsal approved these changes 2021-08-07 18:06:06 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
mirsal
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) BornDeleuze Brooke carla cas (Cassowary) coopcloud decentral1se (d1) fauno (fauno) javielico (Javielico) jjsfunhouse kawaiipunk (KawaiiPunk) knoflook moosemower moritz notplants oxaliq (sorrel) p4u1 renovate-bot (Comrade Renovate Bot) simon stevensting trav (Trav Fryer) yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/traefik#27