coop-cloud/traefik
coop-cloud/traefik
6
1
Fork 11
Code Issues 8 Pull Requests Releases Wiki Activity

Update to handle gandiv5 personal access tokens #49

Merged
decentral1se merged 2 commits from gabi/traefik:gandiv5 into master 2024-10-21 07:52:38 +00:00
Conversation 2 Commits 2 Files Changed 5 +26 -7
gabi commented 2024-10-03 23:47:23 +00:00
Contributor
Copy Link

Added ability to use gandiv5 personal access tokens for wildcard DNS letsencrypt provider

Removed env variable setting from custom entrypoint because it is handled in the traefik container already. Likely this could be done for the other providers as well, i.e. digital ocean and OVH.

Testing: deployed on my hetzner server, no errors shown. have tested similar configuration with bare docker-compose set-up. unsure if classic GANDIV5_API_KEY works anymore, but it should probably be removed because afaict there's no way to get gandi to generate a new API key (although i may be missing it somewhere)

Added ability to use gandiv5 personal access tokens for wildcard DNS letsencrypt provider Removed env variable setting from custom entrypoint because it is handled in the traefik container already. Likely this could be done for the other providers as well, i.e. digital ocean and OVH. Testing: deployed on my hetzner server, no errors shown. have tested similar configuration with bare docker-compose set-up. unsure if classic GANDIV5_API_KEY works anymore, but it should probably be removed because afaict there's no way to get gandi to generate a new API key (although i may be missing it somewhere)
gabi added 1 commit 2024-10-03 23:47:23 +00:00
Update to handle gandiv5 personal access tokens
Some checks failed
continuous-integration/drone/pr Build is failing
Details
e65bffe337
decentral1se reviewed 2024-10-05 10:51:07 +00:00
decentral1se left a comment
Owner
Copy Link

Looking good, thanks for picking this up!

Looking good, thanks for picking this up!
compose.gandi-personal-access-token.yml Outdated
@ -0,0 +10,4 @@
- gandiv5_personal_access_token
secrets:
gandiv5_personal_access_token:
decentral1se commented 2024-10-05 10:50:58 +00:00
Owner
Copy Link

I'd recommended making this much shorter to avoid errors when people have long domain names (${STACK_NAME}), see https://docs.coopcloud.tech/maintainers/handbook/#r015-long-secret-names for more.

I'd recommended making this much shorter to avoid errors when people have long domain names (`${STACK_NAME}`), see https://docs.coopcloud.tech/maintainers/handbook/#r015-long-secret-names for more.
gabi commented 2024-10-07 14:01:43 +00:00
Author
Contributor
Copy Link

Gotcha -- I initially had it shorter, but made it longer for consistency and to match the official traefik containers env naming as documented here: https://go-acme.github.io/lego/dns/gandiv5/

I didn't realize there was a character limit though, thanks so much for flagging! Will take a pass with a shorter name -- it may not pass through transparently into the container, so will probably have to map at some point, but will update when i get a chance to plumb it through :)

Gotcha -- I initially had it shorter, but made it longer for consistency and to match the official traefik containers env naming as documented here: https://go-acme.github.io/lego/dns/gandiv5/ I didn't realize there was a character limit though, thanks so much for flagging! Will take a pass with a shorter name -- it may not pass through transparently into the container, so will probably have to map at some point, but will update when i get a chance to plumb it through :)
🎉 1
gabi commented 2024-10-19 06:50:12 +00:00
Author
Contributor
Copy Link

Okay, actually that was super easy, didn't realize it was just the secret name when i responded last :)

Seems to be working on my test instance, but would appreciate a confirmation before merging in if you have time to test. As far as I can tell, should be good to go though

Okay, actually that was super easy, didn't realize it was just the secret name when i responded last :) Seems to be working on my test instance, but would appreciate a confirmation before merging in if you have time to test. As far as I can tell, should be good to go though
decentral1se marked this conversation as resolved
gabi added 1 commit 2024-10-19 06:29:29 +00:00
Update secret length to follow length guidelines.
Some checks failed
continuous-integration/drone/pr Build is failing
Details
c8894b7ee7
decentral1se approved these changes 2024-10-21 07:52:23 +00:00
decentral1se left a comment
Owner
Copy Link

👏

👏
decentral1se changed title from WIP: Update to handle gandiv5 personal access tokens to Update to handle gandiv5 personal access tokens 2024-10-21 07:52:32 +00:00
decentral1se merged commit 0fac81d4e2 into master 2024-10-21 07:52:38 +00:00
gabi deleted branch gandiv5 2024-10-24 01:42:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud decentral1se fauno flancian Frando iexos javielico kawaiipunk knoflook lambdabundesverband mac-chaffee marlon mayel mirsal moritz nicksellen notplants p4u1 pau renovate-bot rix sef simon stevensting tobias trav val virtualboys wolcen wykwit xynosis yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/traefik#49
No description provided.
Delete Branch "gabi/traefik:gandiv5"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?