chore: upgrade to 3.1.0+2.4.0 #13
Closed
notplants
wants to merge 1 commits from
upgrade-3.1.0+2.4.0 into main
pull from: upgrade-3.1.0+2.4.0
merge into: :main
:main
:mariadb
:upgrade-3.1.0+2.4.0
:sqlite
:maintainer
:rework
:upgrade
:dev-new
:debv
:dev
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
3wordchant
aadil (Aadil Ayub)
abra-bot (Abra Bot)
ammaratef45
amras (Sarma)
Apfelwurm
appletalk
arjan
basebuilder
BornDeleuze
Brooke
carla
cas (Cassowary)
codegod100
coopcloud
cyrnel
decentral1se (d1)
dede
devydave
fauno (fauno)
flancian
Frando
iexos
jade (Jade Ambrose)
javielico (Javielico)
jjsfunhouse
jmakdah2 (Jackie Makdah)
joe-irving (Joe Irving)
kawaiipunk (KawaiiPunk)
knoflook
kolaente
lambdabundesverband
linnealovespie (April)
marlon (marlon)
mayel
mirsal
moosemower
moritz
nicksellen (Nick Sellen)
notplants
oxaliq (sorrel)
p4u1
pau
pharaohgraphy (Andrew 🐦🔥❤️🔥✴️)
PhiNatalie
renovate-bot (Comrade Renovate Bot)
ripclap
rix
rscmbbng
sef (sef)
simon
sixsmith (Sixsmith)
stevensting
tobias
trav (Trav Fryer)
val (val (he/him))
vaznasty
virtualboys
wolcen (Chris Thompson)
wykwit
xynosis
yksflip
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/uptime-kuma#13
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
@stevensting ty for you maintenance of this recipe!
autonomic was doing some scanning recipes we use for CVE, and saw that this recipe needed a version bump to address a CVE so just popped over here to create the PR, if you get a chance to take a look
a276812819toeb4521cc5dHi, thanks for the heads up. Any particular reason why you created this pull request instead of using the two renovate PRs?
I just merged the two PRs, did the release and tested it. I will close this PR. Happy upgrading.
@notplants could you tell me which CVE that was?
thank you @stevensting . the security issue was mentioned here in the release notes https://github.com/louislam/uptime-kuma/releases/tag/2.4.0 although they have not disclosed exactly what it was yet (I think it was probably this one in liquidjs: https://orca.security/resources/blog/critical-rce-in-liquidjs-lets-attackers-execute-arbitrary-commands-on-unpatched-hosts/)
and I had no reason to create the PR instead of use renovate. we were just checking through recipes we used in a systematic way, but glad to hear you have a nice flow with renovate
@stevensting the one difference I see is I added MARIADB_AUTO_UPGRADE=1 (https://hub.docker.com/_/mariadb#mariadb_auto_upgrade) which I thought might have been required for major version bumps of mariadb to work automatically?
but you tested the migration and the db was updated automatically even without that?
@notplants hmm, good point. Yes, everything worked fine without a manual step. the DB got upgraded and mariadb-check gives no errors.
But maybe I should nevertheless put the auto upgrade flag in there for the next upgrade
thats a headscratcher... I wonder why they have the flag if its not actually necessary... but yes seems safer to include it than not haha
Pull request closed