chore: upgrade to 3.1.0+2.4.0 #13

Closed
notplants wants to merge 1 commits from upgrade-3.1.0+2.4.0 into main
Owner

@stevensting ty for you maintenance of this recipe!

autonomic was doing some scanning recipes we use for CVE, and saw that this recipe needed a version bump to address a CVE so just popped over here to create the PR, if you get a chance to take a look

@stevensting ty for you maintenance of this recipe! autonomic was doing some scanning recipes we use for CVE, and saw that this recipe needed a version bump to address a CVE so just popped over here to create the PR, if you get a chance to take a look
notplants added 1 commit 2026-06-09 01:19:50 +00:00
notplants force-pushed upgrade-3.1.0+2.4.0 from a276812819 to eb4521cc5d 2026-06-09 01:26:30 +00:00 Compare
Owner

@stevensting ty for you maintenance of this recipe!

autonomic was doing some scanning recipes we use for CVE, and saw that this recipe needed a version bump to address a CVE so just popped over here to create the PR, if you get a chance to take a look

Hi, thanks for the heads up. Any particular reason why you created this pull request instead of using the two renovate PRs?
I just merged the two PRs, did the release and tested it. I will close this PR. Happy upgrading.

> @stevensting ty for you maintenance of this recipe! > > autonomic was doing some scanning recipes we use for CVE, and saw that this recipe needed a version bump to address a CVE so just popped over here to create the PR, if you get a chance to take a look > Hi, thanks for the heads up. Any particular reason why you created this pull request instead of using the two renovate PRs? I just merged the two PRs, did the release and tested it. I will close this PR. Happy upgrading.
stevensting closed this pull request 2026-06-09 09:09:36 +00:00
Owner

@notplants could you tell me which CVE that was?

@notplants could you tell me which CVE that was?
Author
Owner

thank you @stevensting . the security issue was mentioned here in the release notes https://github.com/louislam/uptime-kuma/releases/tag/2.4.0 although they have not disclosed exactly what it was yet (I think it was probably this one in liquidjs: https://orca.security/resources/blog/critical-rce-in-liquidjs-lets-attackers-execute-arbitrary-commands-on-unpatched-hosts/)

and I had no reason to create the PR instead of use renovate. we were just checking through recipes we used in a systematic way, but glad to hear you have a nice flow with renovate

thank you @stevensting . the security issue was mentioned here in the release notes https://github.com/louislam/uptime-kuma/releases/tag/2.4.0 although they have not disclosed exactly what it was yet (I think it was probably this one in liquidjs: https://orca.security/resources/blog/critical-rce-in-liquidjs-lets-attackers-execute-arbitrary-commands-on-unpatched-hosts/) and I had no reason to create the PR instead of use renovate. we were just checking through recipes we used in a systematic way, but glad to hear you have a nice flow with renovate
Author
Owner

@stevensting the one difference I see is I added MARIADB_AUTO_UPGRADE=1 (https://hub.docker.com/_/mariadb#mariadb_auto_upgrade) which I thought might have been required for major version bumps of mariadb to work automatically?

but you tested the migration and the db was updated automatically even without that?

@stevensting the one difference I see is I added MARIADB_AUTO_UPGRADE=1 (https://hub.docker.com/_/mariadb#mariadb_auto_upgrade) which I thought might have been required for major version bumps of mariadb to work automatically? but you tested the migration and the db was updated automatically even without that?
Owner

@stevensting the one difference I see is I added MARIADB_AUTO_UPGRADE=1 (https://hub.docker.com/_/mariadb#mariadb_auto_upgrade) which I thought might have been required for major version bumps of mariadb to work automatically?

but you tested the migration and the db was updated automatically even without that?

@notplants hmm, good point. Yes, everything worked fine without a manual step. the DB got upgraded and mariadb-check gives no errors.
But maybe I should nevertheless put the auto upgrade flag in there for the next upgrade

> @stevensting the one difference I see is I added MARIADB_AUTO_UPGRADE=1 (https://hub.docker.com/_/mariadb#mariadb_auto_upgrade) which I thought might have been required for major version bumps of mariadb to work automatically? > > but you tested the migration and the db was updated automatically even without that? @notplants hmm, good point. Yes, everything worked fine without a manual step. the DB got upgraded and mariadb-check gives no errors. But maybe I should nevertheless put the auto upgrade flag in there for the next upgrade
Author
Owner

thats a headscratcher... I wonder why they have the flag if its not actually necessary... but yes seems safer to include it than not haha

thats a headscratcher... I wonder why they have the flag if its not actually necessary... but yes seems safer to include it than not haha

Pull request closed

Sign in to join this conversation.