@jeppebundsgaard can you open up a new issue with the output of the command while using --debug? Thanks!
hey @jeppebundsgaard, thanks for raising the issue! I think it should probably have ended up here as it is a more general issue but let's…
Oh wait a sec, you need to bump the config version:
Hey, I think toolshed/abra#706 (comment) still applies, nowhere else in the history of the recipe config commons have we ever used 0.0.0 and I fear this might break something else.
If you log.Fatal(err) in a function, you should (in the world of Golang) be sending back that error. log.Fatal gets hard to track when you call a function in a function in a function etc. So, I would do here (string, error) and instead of log.Fatal(err) I would do return "", err . In some cases, you can even return "", fmt.Errorf(i18n.G("my cool translated explanation of the error with additional context: %s"), err). See other error handling elsewhere for more context. In general, we need to thread all errors back to the CLI main command function and only there will the log.Fatal happen. This is at least, the idea.
Thank you so much @ammaratef45! I've tried to send some breadcrumbs about what I think might be the issue, similarly to toolshed/abra#706. I think we're getting closer to the culprit on this one but not quite there... see what you think about i!
Jeebus, with a quick scan over https://git.coopcloud.tech/toolshed/abra/src/branch/main/cli/app/list.go I think we are indeed not pulling in the latest for recipes! This would seem to be a bug…
Documentation patches welcome!
AFAIK abra app upgrade does fetch the latest from the recipe:
if err := app.Recipe.Ensure(recipe.EnsureContext{ |
|
Chaos: internal.Chaos, |
|
Offline: internal.Offline, |
|
// Ignore the env version for now, to make sure we are at the latest commit. |
|
// This enables us to get release notes, that were added after a release. |
|
IgnoreEnvVersion: true, |
|
}); err != nil { |
|
log.Fatal(err) |
Running…