moritz/alakazam
1
1
Fork 4
Code Issues 2 Pull Requests 1 Packages Projects Releases Wiki Activity

Config in CWD and resolve ABRA_DIR #4

Open
dannygroenewegen wants to merge 1 commits from eCommons/alakazam:config-location into main
pull from: eCommons/alakazam:config-location
merge into: moritz:main
Conversation 1 Commits 1 Files Changed 1 +30 -7
dannygroenewegen commented 2026-04-07 12:27:35 +00:00
First-time contributor
Copy Link

Added support for reading alakazam.yml from CWD and fallback to ~/.config/alakazam.yml. This allows working with a completely separate path for e.g. development.
I also had abra configured with a different abra_dir. When alakazam runs abra, it uses the configured abra dir, but alakazam also had some hardcoded references to ~/.abra. I added get_abra_dir() with the same logic that abra uses internally and replaced all hardcoded references.

  • Support alakazam.yml in CWD
  • Resolve ABRA_DIR using env var or abra.yml instead of hardcoding ~/.abra
  • Add ABRA_DIR to exclude_paths when inside root
Added support for reading alakazam.yml from CWD and fallback to ~/.config/alakazam.yml. This allows working with a completely separate path for e.g. development. I also had abra configured with a different abra_dir. When alakazam runs abra, it uses the configured abra dir, but alakazam also had some hardcoded references to ~/.abra. I added get_abra_dir() with the same logic that abra uses internally and replaced all hardcoded references. - Support alakazam.yml in CWD - Resolve ABRA_DIR using env var or abra.yml instead of hardcoding ~/.abra - Add ABRA_DIR to exclude_paths when inside root
🎉 1
dannygroenewegen added 1 commit 2026-04-07 12:27:37 +00:00
- Support alakazam.yml in CWD f1abf6229f 
- Resolve ABRA_DIR using env var or abra.yml instead of hardcoding ~/.abra
- Add ABRA_DIR to exclude_paths when inside root
decentral1se reviewed 2026-04-08 21:48:38 +00:00
decentral1se left a comment
First-time contributor
Copy Link

Woah, super cool @dannygroenewegen! Great to see this happening. Driving by but LGTM! Not to demand too much but probably it would be pretty easy to create a unit test for get_abra_dir. We have to start writing tests eventually 🙃 I trust @moritz will know better.

Woah, super cool @dannygroenewegen! Great to see this happening. Driving by but LGTM! Not to demand too much but probably it would be pretty easy to create a unit test for `get_abra_dir`. We have to start writing tests eventually 🙃 I trust @moritz will know better.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u config-location:eCommons-config-location
git checkout eCommons-config-location
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
simon moritz
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: moritz/alakazam#4
No description provided.
Delete Branch "eCommons/alakazam:config-location"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?