notplants
notplants commented on pull request PeachCloud/peach-workspace#30 2021-11-18 09:10:47 +00:00
Separate network settings and status templates

LGTM.

clean kitchen, clean routes, tasty soup

notplants deleted branch get_about from PeachCloud/go-sbotcli-rs 2021-11-18 09:08:11 +00:00
notplants closed pull request PeachCloud/go-sbotcli-rs#7 2021-11-18 09:08:06 +00:00
WIP: Add abstract get_about_message function
notplants commented on pull request PeachCloud/go-sbotcli-rs#8 2021-11-17 12:29:12 +00:00
WIP: Change go-sbotcli-rs to parse json responses instead of using regex matches

The problem is one of time and skill. Who can / will modify the Go code to be compatible with static compilation? How long will that take? Would we rather delay the release of PeachPub (might be…

notplants commented on pull request PeachCloud/go-sbotcli-rs#8 2021-11-17 12:27:38 +00:00
WIP: Change go-sbotcli-rs to parse json responses instead of using regex matches

But it's not just returning general data structures, right? It seemed like your intention was to make it super convenient by grouping the results of various sbot calls into more complex structures.…

notplants commented on pull request PeachCloud/go-sbotcli-rs#8 2021-11-17 12:04:25 +00:00
WIP: Change go-sbotcli-rs to parse json responses instead of using regex matches

It's the exact same work being done, just split into two.

I think there may be cases where the low-level calls already return the strings we want, or we don't need to parse the result, in which…

notplants commented on pull request PeachCloud/go-sbotcli-rs#8 2021-11-17 11:48:06 +00:00
WIP: Change go-sbotcli-rs to parse json responses instead of using regex matches

posted on ssb too just to see if anyone has an opinion

notplants commented on pull request PeachCloud/go-sbotcli-rs#8 2021-11-17 11:08:48 +00:00
WIP: Change go-sbotcli-rs to parse json responses instead of using regex matches

another advantage of pushing forward on this approach is we would make it easier for people to also make these FFI bindings in other languages besides rust

notplants commented on pull request PeachCloud/go-sbotcli-rs#8 2021-11-17 11:02:39 +00:00
WIP: Change go-sbotcli-rs to parse json responses instead of using regex matches

ok here is a slight variant approach to consider:

https://legionlabs.com/blog/rust_ffi_finding/

found based on @soapdog…

notplants commented on pull request PeachCloud/go-sbotcli-rs#8 2021-11-17 10:55:37 +00:00
WIP: Change go-sbotcli-rs to parse json responses instead of using regex matches

one more potential downside of two libraries:

potentially will have to write some functions twice.

If peach-web instantiates an instance of Sbot from the high-level library, then maybe it…

notplants commented on pull request PeachCloud/go-sbotcli-rs#8 2021-11-17 10:48:04 +00:00
WIP: Change go-sbotcli-rs to parse json responses instead of using regex matches

I think mostly on the same page, but I still dont know that most libary users would be more likely to use go-sbotcli-rs than peach-sbot.

Which also makes me wonder if it should be called…

notplants commented on pull request PeachCloud/go-sbotcli-rs#8 2021-11-17 09:54:45 +00:00
WIP: Change go-sbotcli-rs to parse json responses instead of using regex matches

what would you call the two libraries?

notplants commented on pull request PeachCloud/go-sbotcli-rs#8 2021-11-17 09:52:40 +00:00
WIP: Change go-sbotcli-rs to parse json responses instead of using regex matches

Could also be one library, which includes both the low-level calls (one-to-one correspondence with sbotcli calls), as well as additional higher level calls, and the library user (such as us, in…

notplants commented on pull request PeachCloud/go-sbotcli-rs#8 2021-11-17 09:42:24 +00:00
WIP: Change go-sbotcli-rs to parse json responses instead of using regex matches

This feels to me like deciding whether we want one or two libraries. And would mostly be a small distinction, as the parsing still needs to live somewhere.

Many API libraries will do parsing and…

notplants commented on pull request PeachCloud/go-sbotcli-rs#8 2021-11-16 15:17:03 +00:00
WIP: Change go-sbotcli-rs to parse json responses instead of using regex matches

Questions about what sbotcli calls to use to get the right filters will effect this code, but this is a basic PR going in the direction of parsing json, if we decide thats what we want to do @glyph

notplants pushed to parse-json at PeachCloud/go-sbotcli-rs 2021-11-16 15:15:55 +00:00
5fa1955b99 Working on about messages
notplants pushed to parse-json at PeachCloud/go-sbotcli-rs 2021-11-16 15:06:47 +00:00
4fbc22967b Change get_about_message to parse json