notplants
notplants deleted branch forgot-password from PeachCloud/peach-workspace 2021-11-10 13:58:24 +00:00
notplants merged pull request PeachCloud/peach-workspace#19 2021-11-10 13:58:18 +00:00
Change /send_password_reset to /forgot_password
notplants pushed to main at PeachCloud/peach-workspace 2021-11-10 13:58:18 +00:00
82a87706b7 Merge pull request 'Change /send_password_reset to /forgot_password' (#19) from forgot-password into main
982d5d2811 Merge branch 'main' into forgot-password
ae9254c0c6 Changes to CSS
a4f459e1fc Change /send_password_reset to /forgot_password
Compare 4 commits »
notplants pushed to forgot-password at PeachCloud/peach-workspace 2021-11-10 13:57:51 +00:00
982d5d2811 Merge branch 'main' into forgot-password
a4e0f7d7fe Merge pull request 'Create authentication request guard' (#17) from auth into main
Compare 2 commits »
notplants commented on pull request PeachCloud/peach-workspace#19 2021-11-10 13:57:33 +00:00
Change /send_password_reset to /forgot_password

forgot-password was accidentally put as a class name while I was trying to figure out how to style it lol

notplants commented on pull request PeachCloud/peach-workspace#19 2021-11-10 13:57:12 +00:00
Change /send_password_reset to /forgot_password

Thanks, made these changes. I'm not totally aware of all of the classes are available in the pattern library, but will hopefully become aware of more of them over time through code reviews. Please…

notplants pushed to forgot-password at PeachCloud/peach-workspace 2021-11-10 13:53:23 +00:00
ae9254c0c6 Changes to CSS
notplants created pull request PeachCloud/peach-workspace#19 2021-11-10 11:38:33 +00:00
Change /send_password_reset to /forgot_password
notplants created branch forgot-password in PeachCloud/peach-workspace 2021-11-10 11:37:03 +00:00
notplants pushed to forgot-password at PeachCloud/peach-workspace 2021-11-10 11:37:03 +00:00
a4f459e1fc Change /send_password_reset to /forgot_password
notplants merged pull request PeachCloud/peach-workspace#17 2021-11-10 11:35:47 +00:00
Create authentication request guard
notplants pushed to main at PeachCloud/peach-workspace 2021-11-10 11:35:47 +00:00
a4e0f7d7fe Merge pull request 'Create authentication request guard' (#17) from auth into main
e3640f0885 Clean up comments
309ec94cdb Allow large enum variant to avoid clippy warning
0d23307f86 Use empty struct for Authenticated
6605af7bed Fix clippy errors
Compare 8 commits »
notplants deleted branch auth from PeachCloud/peach-workspace 2021-11-10 11:35:47 +00:00
notplants pushed to auth at PeachCloud/peach-workspace 2021-11-10 11:35:19 +00:00
notplants pushed to auth at PeachCloud/peach-workspace 2021-11-10 11:33:42 +00:00
a4f459e1fc Change /send_password_reset to /forgot_password
e3640f0885 Clean up comments
Compare 2 commits »
notplants commented on pull request PeachCloud/peach-workspace#17 2021-11-09 11:47:52 +00:00
Create authentication request guard

Do you know the lifespan of the cookies which are currently being served? I wonder what an appropriate duration would be?

The default expiration for a private cooke is one week…

notplants commented on pull request PeachCloud/peach-workspace#17 2021-11-09 11:36:24 +00:00
Create authentication request guard

aw interesting, I now see when you click "resolve" they dont entirely disappear and be re-shown. thats a nice feature for using the comments like a todo list. assuming my replies to comments dont get…

notplants commented on pull request PeachCloud/peach-workspace#17 2021-11-09 11:32:37 +00:00
Create authentication request guard

wow I am super happy to know about this as a possible alternate syntax for handling success/error, thanks for sharing

this seems quite ergonomic

I also dont have a strong preference

notplants commented on pull request PeachCloud/peach-workspace#17 2021-11-09 11:27:56 +00:00
Create authentication request guard

thanks!

stale comments are a source of great possible confusion

notplants commented on pull request PeachCloud/peach-workspace#17 2021-11-09 11:24:46 +00:00
Create authentication request guard

"iff" is a shorthand that means "if and only if" (https://en.wikipedia.org/wiki/If_and_only_if),

for now I changed the comment to say "if and only if", but "iff" is a pretty useful acronym,…