toolshed/abra
4
3
Fork 18
Code Issues 34 Pull Requests 4 Packages Releases 42 Activity

add a label to signal that a deploy is connected with a recipe #264

Merged
moritz merged 2 commits from moritz/abra:recipe_label into main 2023-01-31 14:36:07 +00:00
Conversation 1 Commits 2 Files Changed 4 +15
moritz commented 2023-01-31 10:35:10 +00:00
Member
Copy Link

Resolves coop-cloud/organising#391 by adding the following label coop-cloud.${STACK_NAME}.recipe=${RECIPE} (according to the version label).
This is required for the auto updater coop-cloud/organising#236 (comment)

Resolves https://git.coopcloud.tech/coop-cloud/organising/issues/391 by adding the following label `coop-cloud.${STACK_NAME}.recipe=${RECIPE}` (according to the version label). This is required for the auto updater https://git.coopcloud.tech/coop-cloud/organising/issues/236#issuecomment-15390
decentral1se approved these changes 2023-01-31 13:03:09 +00:00
decentral1se left a comment
Owner
Copy Link

LGTM! Much appreciated to see these split up into separate PRs, great Git praxis!

LGTM! Much appreciated to see these split up into separate PRs, great Git praxis!
pkg/config/app.go Outdated
@ -449,1 +449,4 @@
}
// add a label to signal that a deploy is connected with a recipe
func SetRecipeLabel(compose *composetypes.Config, stackName string, recipe string) {
decentral1se commented 2023-01-31 13:02:28 +00:00
Owner
Copy Link
// SetRecipeLabel ...
``` // SetRecipeLabel ... ```
moritz marked this conversation as resolved
pkg/config/app.go Outdated
@ -450,0 +452,4 @@
func SetRecipeLabel(compose *composetypes.Config, stackName string, recipe string) {
for _, service := range compose.Services {
if service.Name == "app" {
logrus.Debugf("set recipe label to %s", recipe)
decentral1se commented 2023-01-31 13:02:43 +00:00
Owner
Copy Link

More app/recipe info comment again.

More app/recipe info comment again.
moritz marked this conversation as resolved
moritz force-pushed recipe_label from 98c937b825 to 23a0b92d88 2023-01-31 14:25:47 +00:00 Compare
moritz added 1 commit 2023-01-31 14:31:44 +00:00
resolve PR: include the service info in the log message
Some checks failed
continuous-integration/drone/pr Build is failing
Details
5b74a56294
moritz merged commit 50db39424c into main 2023-01-31 14:36:06 +00:00
moritz deleted branch recipe_label 2023-01-31 14:36:21 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
installer
Everything to do with the install script.
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moritz notplants p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#264
No description provided.
Delete Branch "moritz/abra:recipe_label"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?