add label to enable/disable the auto update process #267

2023-01-31T12:42:46Z

moritz commented

2023-01-31 12:42:46 +00:00

A suggestion for enabling/disabling automatic updates per env variable ENABLE_AUTO_UPDATE=true.
This is required for the auto updater coop-cloud/organising#236 (comment)

It adds the label coop-cloud.${STACK_NAME}.autoupdate=${ENABLE_AUTO_UPDATE}.
With a label it is easier to access the value without parsing all the environment variables.

A suggestion for enabling/disabling automatic updates per env variable `ENABLE_AUTO_UPDATE=true`. This is required for the auto updater https://git.coopcloud.tech/coop-cloud/organising/issues/236#issuecomment-14870 It adds the label `coop-cloud.${STACK_NAME}.autoupdate=${ENABLE_AUTO_UPDATE}`. With a label it is easier to access the value without parsing all the environment variables.

decentral1se approved these changes

2023-01-31 12:58:04 +00:00

decentral1se left a comment

This looks legit to me!

It seems consisent to me that we'd require people to opt-in to auto-update. That does assume that a missing label = don't update. Assume that will be reflected in the auto-updater logic.

I think this change is missing docs, do you want to write them now? It's OK if you want to keep experimenting first. In that case, I'd open up a separate ticket so we remember to document what we're doing.

Maybe @3wordchant @knoflook have a review for this?

This looks legit to me! It seems consisent to me that we'd require people to opt-in to auto-update. That does assume that a missing label = don't update. Assume that will be reflected in the auto-updater logic. I think this change is missing docs, do you want to write them now? It's OK if you want to keep experimenting first. In that case, I'd open up a separate ticket so we remember to document what we're doing. Maybe @3wordchant @knoflook have a review for this?

pkg/config/app.go Outdated

						
				@@ -448,2 +448,4 @@

					return compose, nil

				}

				// add env ENABLE_AUTO_UPDATE as label to enable/disable the auto update process for this app

decentral1se commented

2023-01-31 12:55:49 +00:00

Go doc needs a thing like the following to generate well:

// SetUpdateLabel adds an env ...

Go doc needs a thing like the following to generate well: ```go // SetUpdateLabel adds an env ... ```

moritz marked this conversation as resolved

moritz force-pushed update_label from 79fd23695e to 6774893412

2023-01-31 15:14:43 +00:00

Compare

moritz added 1 commit 2023-01-31 15:19:51 +00:00

resolve PR: include the service info in the log message

continuous-integration/drone/push Build is failing

Details

76717531bd

decentral1se merged commit 76717531bd into main

2023-02-01 06:25:44 +00:00

moritz deleted branch update_label

2023-02-01 11:15:20 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/abra#267

Allow edits from maintainers