toolshed/abra
toolshed/abra
4
2
Fork 16
Code Issues 6 Pull Requests Packages Releases 37 Activity

app ls --status shows more detailles about the deployment state #280

Merged
moritz merged 8 commits from detailed_app_list into main 2023-03-07 12:32:19 +00:00
Conversation 0 Commits 8 Files Changed 5 +76 -19
moritz commented 2023-03-01 11:39:41 +00:00
Member
Copy Link

This PR adds the chaos state, the chaos version and the autoupdate state to the deployment details of abra app ls --status.
The label coop-cloud.<app_name>.chaos_version is used to store the chaos version. This solves coop-cloud/organising#429

This PR adds the chaos state, the chaos version and the autoupdate state to the deployment details of `abra app ls --status`. The label `coop-cloud.<app_name>.chaos_version` is used to store the chaos version. This solves https://git.coopcloud.tech/coop-cloud/organising/issues/429
decentral1se reviewed 2023-03-05 10:32:36 +00:00
decentral1se left a comment
Owner
Copy Link

Amazing work @moritz! Love this change and it will really help us. The table output is getting quite long now, so I'm wondering if folks have concerns about that? I think each column is pretty useful to have. Especially when we have a chaos deployment label but no version, that can happen with todays abra. But then again, that won't be the case later, in say, a years time? If you have a chaos labeled deploy then you will have the version? We could merge these columns potentially, I'm not sure. Or maybe remove it later on?

Amazing work @moritz! Love this change and it will really help us. The table output is getting quite long now, so I'm wondering if folks have concerns about that? I think each column is pretty useful to have. Especially when we have a chaos deployment label but no version, that can happen with todays `abra`. But then again, that won't be the case later, in say, a years time? If you have a chaos labeled deploy then you will have the version? We could merge these columns potentially, I'm not sure. Or maybe remove it later on?
cli/app/rollback.go Outdated
@ -183,6 +183,7 @@ recipes.
config.ExposeAllEnv(stackName, compose, app.Env)
config.SetRecipeLabel(compose, stackName, app.Recipe)
config.SetChaosLabel(compose, stackName, internal.Chaos)
config.SetChaosVersionLabel(compose, app.StackName(), chosenDowngrade)
decentral1se commented 2023-03-05 10:23:07 +00:00
Owner
Copy Link

app.StackName() -> stackName

`app.StackName()` -> `stackName`
moritz marked this conversation as resolved
cli/app/upgrade.go Outdated
@ -194,6 +194,7 @@ recipes.
config.ExposeAllEnv(stackName, compose, app.Env)
config.SetRecipeLabel(compose, stackName, app.Recipe)
config.SetChaosLabel(compose, stackName, internal.Chaos)
config.SetChaosVersionLabel(compose, app.StackName(), chosenUpgrade)
decentral1se commented 2023-03-05 10:23:23 +00:00
Owner
Copy Link

app.StackName() -> stackName

`app.StackName()` -> `stackName`
moritz marked this conversation as resolved
cli/internal/deploy.go Outdated
@ -139,6 +139,7 @@ func DeployAction(c *cli.Context) error {
config.ExposeAllEnv(app.StackName(), compose, app.Env)
config.SetRecipeLabel(compose, app.StackName(), app.Recipe)
config.SetChaosLabel(compose, app.StackName(), Chaos)
config.SetChaosVersionLabel(compose, app.StackName(), version)
decentral1se commented 2023-03-05 10:23:55 +00:00
Owner
Copy Link

Oops, can we make all the app.StackName() calls one stackName too? To avoid computing this several times...

Oops, can we make all the `app.StackName()` calls one `stackName` too? To avoid computing this several times...
moritz marked this conversation as resolved
pkg/config/app.go Outdated
@ -407,0 +409,4 @@
result["chaos"] = chaos
}
labelKey = fmt.Sprintf("coop-cloud.%s.chaos_version", name)
decentral1se commented 2023-03-05 10:24:23 +00:00
Owner
Copy Link

chaos_version -> chaos-version following the convention of -? This would require updating in several places in this PR.

`chaos_version` -> `chaos-version` following the convention of `-`? This would require updating in several places in this PR.
moritz marked this conversation as resolved
pkg/config/app.go Outdated
@ -407,0 +414,4 @@
result["chaosVersion"] = chaosVersion
}
labelKey = fmt.Sprintf("coop-cloud.%s.autoupdate", name)
decentral1se commented 2023-03-05 10:25:11 +00:00
Owner
Copy Link

Is autoupdate -> auto-update potentially more readable?

Is `autoupdate` -> `auto-update` potentially more readable?
moritz commented 2023-03-07 12:18:08 +00:00
Author
Member
Copy Link

This would be a bit more readable but it would break kadabra for for all apps that are deployed with the current abra version.
Kadabra is still alpha, so breaking changes are part of it, but I don't think this label change is really worth the effort to redeploy all apps after the next abra release.

This would be a bit more readable but it would break kadabra for for all apps that are deployed with the current abra version. Kadabra is still alpha, so breaking changes are part of it, but I don't think this label change is really worth the effort to redeploy all apps after the next abra release.
👍 1
decentral1se marked this conversation as resolved
moritz force-pushed detailed_app_list from 4bb2fb6b63 to edff63b446 2023-03-07 12:25:51 +00:00 Compare
moritz merged commit 0ce8b3a5c2 into main 2023-03-07 12:32:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
build

go build related issues

  
ci/cd

Building things with CI/CD

  
contributing

Dealing with contributing

  
design

UI/UX

  
documentation

Documenting all the things

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
meta

relating to the project or repo itself

  
question

More information is needed

  
release

Release management

  
release-candidate

Related to the new release candidate

  
security

Security related

  
test

Unit/integration testing

  
wontfix

This won't be fixed

No Label
bug
build
ci/cd
contributing
design
documentation
duplicate
enhancement
help wanted
invalid
meta
question
release
release-candidate
security
test
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/abra#280
No description provided.
Delete Branch "detailed_app_list"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?