toolshed/abra
4
3
Fork 18
Code Issues 34 Pull Requests 4 Packages Releases 42 Activity

feat(deploy): set timeout via label #290

Merged
moritz merged 2 commits from set_timeout into main 2023-04-14 14:44:23 +00:00
Conversation 1 Commits 2 Files Changed 5 +45 -4
moritz commented 2023-04-13 15:49:39 +00:00
Member
Copy Link

Solves coop-cloud/organising#437

A timeout can be specified globally for a recipe using this label:
coop-cloud.${STACK_NAME}.timeout=${TIMEOUT:-120}. This sets the default timeout to 120s. An app specific timeout can be set using the env TIMEOUT.

Solves https://git.coopcloud.tech/coop-cloud/organising/issues/437 A timeout can be specified globally for a recipe using this label: `coop-cloud.${STACK_NAME}.timeout=${TIMEOUT:-120}`. This sets the default timeout to 120s. An app specific timeout can be set using the env `TIMEOUT`.
decentral1se reviewed 2023-04-14 11:47:16 +00:00
decentral1se left a comment
Owner
Copy Link

Solid stuff, few minor comments also! Thanks!

Solid stuff, few minor comments also! Thanks!
cli/app/upgrade.go
@ -201,6 +202,15 @@ recipes.
logrus.Fatal(err)
}
timeoutLabel := config.GetLabel(compose, stackName, "timeout")
decentral1se commented 2023-04-14 11:46:09 +00:00
Owner
Copy Link

Since we do this GetLabel / strconv.Atoi(timeoutLabel) twice already, should we also publish a config.GetTimeoutLabel API which does this all internally? Then the surface can be:

stack.WaitTimeout, err = config.GetTimeoutLabel(...)
if err != nil {
 ...
}
Since we do this `GetLabel` / `strconv.Atoi(timeoutLabel)` twice already, should we also publish a `config.GetTimeoutLabel` API which does this all internally? Then the surface can be: ```go stack.WaitTimeout, err = config.GetTimeoutLabel(...) if err != nil { ... } ```
moritz marked this conversation as resolved
pkg/upstream/stack/stack.go
@ -31,6 +31,8 @@ const (
ResolveImageNever = "never"
)
var WaitTimeout int = 50
decentral1se commented 2023-04-14 11:46:52 +00:00
Owner
Copy Link

Shall we doc string this also and mention 50 is random + legacy choice?

Shall we doc string this also and mention `50` is random + legacy choice?
moritz marked this conversation as resolved
moritz force-pushed set_timeout from bc109d77ec to c750db465d 2023-04-14 12:38:10 +00:00 Compare
moritz force-pushed set_timeout from f717cb4e14 to d3650b274e 2023-04-14 14:31:29 +00:00 Compare
moritz merged commit 31ec322c55 into main 2023-04-14 14:44:22 +00:00
moritz deleted branch set_timeout 2023-04-14 14:44:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
installer
Everything to do with the install script.
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moritz notplants p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#290
No description provided.
Delete Branch "set_timeout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?