toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

fix: dont always download the catalogue #422

Merged
decentral1se merged 1 commits from catalogue-download-less into main 2024-06-25 14:50:59 +00:00
Conversation 1 Commits 1 Files Changed 1 -5
decentral1se commented 2024-06-25 14:49:56 +00:00
Owner
Copy Link

See coop-cloud/organising#592. I'm fairly sure issues would be caught by this while working on coop-cloud/organising#584 so I'm fairly confident this isn't going to bork everything after some manual testing... here's hoping! Everything seems to call ReadRecipeCatalogue on demand when requiring the catalogue and this downloads the necessary stuff then.

See https://git.coopcloud.tech/coop-cloud/organising/issues/592. I'm fairly sure issues would be caught by this while working on https://git.coopcloud.tech/coop-cloud/organising/issues/584 so I'm fairly confident this isn't going to bork everything after some manual testing... here's hoping! Everything seems to call `ReadRecipeCatalogue` on demand when requiring the catalogue and this downloads the necessary stuff then.
🎉 1
decentral1se added 1 commit 2024-06-25 14:49:57 +00:00
fix: dont always download the catalogue
Some checks failed
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is failing
Details
f58522d822 
See coop-cloud/organising#592
decentral1se merged commit f58522d822 into main 2024-06-25 14:50:59 +00:00
decentral1se deleted branch catalogue-download-less 2024-06-25 14:51:01 +00:00
p4u1 commented 2024-06-25 16:28:39 +00:00
Member
Copy Link

Nice, this was bugging me aswell! If the catalogue needs to be updated it should be done in the command implementation

Nice, this was bugging me aswell! If the catalogue needs to be updated it should be done in the command implementation
👍 1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#422
No description provided.
Delete Branch "catalogue-download-less"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?