toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

feat: git hash arg for deploy #434

Merged
decentral1se merged 6 commits from git-hash-arg into main 2024-07-09 09:42:57 +00:00
Conversation 5 Commits 6 Files Changed 33 +310 -207
decentral1se commented 2024-07-09 09:42:39 +00:00
Owner
Copy Link

See coop-cloud/organising#517.

I changed the design and actually don't allow git hashes on upgrade/rollback.

This is due to there being loooooads of logic which does comparisons, release notes, etc. for versions in those commands. It's hard to separate that all from this chaos commit path. Also, the UI is unclear: do I deploy/upgrade/rollback to deploy a chaos commit? And when is a chaos commit a rollback and not an upgrade in relation to a version?

This could technically be worked out but I think it's easier to just say "you're on your own" for chaos commits on deploy. And the UI surface for deploy is the "center for chaos". Then upgrade/rollback deals exclusively with recipe versions and deployments which remove "chaos".

Some additional cleaning commits re: docstrings. Stuff was out-of-date or duplicated elsewhere, so I made it more terse. Also additional tests for stuff when I was poking around in the upgrade/rollback code.

See https://git.coopcloud.tech/coop-cloud/organising/issues/517. I changed the design and actually *don't* allow git hashes on `upgrade`/`rollback`. This is due to there being *loooooads* of logic which does comparisons, release notes, etc. for versions in those commands. It's hard to separate that all from this chaos commit path. Also, the UI is unclear: do I `deploy`/`upgrade`/`rollback` to deploy a chaos commit? And when is a chaos commit a `rollback` and not an `upgrade` in relation to a `version`? This could technically be worked out but I think it's easier to just say "you're on your own" for chaos commits on `deploy`. And the UI surface for `deploy` is the "center for chaos". Then `upgrade`/`rollback` deals exclusively with recipe versions and deployments which remove "chaos". Some additional cleaning commits re: docstrings. Stuff was out-of-date or duplicated elsewhere, so I made it more terse. Also additional tests for stuff when I was poking around in the `upgrade`/`rollback` code.
🎉 2
decentral1se added 6 commits 2024-07-09 09:42:39 +00:00 
See coop-cloud/organising#517
test: recipe test fixups
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
7f910b4e5b
decentral1se merged commit 7f910b4e5b into main 2024-07-09 09:42:57 +00:00
decentral1se deleted branch git-hash-arg 2024-07-09 09:42:58 +00:00
p4u1 commented 2024-07-09 16:50:59 +00:00
Member
Copy Link

Nice stuff! And I agree with the design decision

Nice stuff! And I agree with the design decision
❤️ 1
moritz commented 2024-07-15 16:10:49 +00:00
Member
Copy Link

Finally 🚀 I really like this feature 🥳
But I'm not sure if it's a good idea if you're not able to upgrade to any arbitrary version. Especially to test a version before releasing it.

Finally 🚀 I really like this feature 🥳 But I'm not sure if it's a good idea if you're not able to `upgrade` to any arbitrary version. Especially to test a version before releasing it.
🎉 1
p4u1 commented 2024-07-15 16:51:04 +00:00
Member
Copy Link

Can you not test the new version using abra app deploy --chaos?

Can you not test the new version using abra app deploy --chaos?
moritz commented 2024-07-15 17:22:02 +00:00
Member
Copy Link

Can you not test the new version using abra app deploy --chaos?

Sorry you are right, I forgot that abra app deploy --chaos is mostly doing the same like abra app upgarde --chaos, as it also doing an in-place upgrade and I don't need to undeploy the app.

> Can you not test the new version using abra app deploy --chaos? Sorry you are right, I forgot that `abra app deploy --chaos` is mostly doing the same like `abra app upgarde --chaos`, as it also doing an in-place upgrade and I don't need to undeploy the app.
👍 1
decentral1se commented 2024-07-15 20:41:37 +00:00
Author
Owner
Copy Link

Nice! afair abra app deploy <hash> will trigger a chaos deploy, no --chaos required 😌 And yes, the behaviour of upgrade/rollback is now finally changing from deploy. which is IMHO a good thing and less confusing. just we need to change our habits 🙃

Nice! afair `abra app deploy <hash>` will trigger a chaos deploy, no `--chaos` required 😌 And yes, the behaviour of `upgrade`/`rollback` is now finally changing from `deploy`. which is IMHO a good thing and less confusing. just we need to change our habits 🙃
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#434
No description provided.
Delete Branch "git-hash-arg"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?