feat: abra app move (continued) #636

Merged
decentral1se merged 4 commits from abra-app-move-continued into main 2025-09-01 09:22:10 +00:00
Owner

Pushing #605 from @p4u1 forward 🧗

Pushing https://git.coopcloud.tech/toolshed/abra/pulls/605 from @p4u1 forward 🧗
decentral1se added 3 commits 2025-09-01 05:44:32 +00:00
chore: make i18n
Some checks failed
continuous-integration/drone/push Build is failing
continuous-integration/drone/pr Build is failing
da6fdbd5d4
decentral1se added 1 commit 2025-09-01 05:46:10 +00:00
fixup! refactor: app move review pass
Some checks failed
continuous-integration/drone/push Build is failing
d7c57570a5
decentral1se added 1 commit 2025-09-01 05:48:37 +00:00
fixup! fixup! refactor: app move review pass
Some checks failed
continuous-integration/drone/push Build is failing
51c1738ec9
decentral1se force-pushed abra-app-move-continued from 51c1738ec9 to 5479a51b23 2025-09-01 05:50:28 +00:00 Compare
decentral1se force-pushed abra-app-move-continued from 5479a51b23 to dbc41a0ffc 2025-09-01 05:52:57 +00:00 Compare
decentral1se force-pushed abra-app-move-continued from dbc41a0ffc to f4b42b3d1b 2025-09-01 05:53:29 +00:00 Compare
decentral1se force-pushed abra-app-move-continued from f4b42b3d1b to f0e2b012c6 2025-09-01 09:18:04 +00:00 Compare
Author
Owner

Notes from the code cave:

  • I tried to make it possible to app move an app on the same server for the purposes of testing 😂 This complicated everything so much that it became impossible to read the code anymore. I have abandoned this for now.
  • Due to the chaotic nature of what people put on containers, a lot of containers won't be moveable. For example, all the "distroless" containers won't be supported because you can't sudo cat .... I've added this to the --help output update: it's portable: #636 (comment)
  • Use rsync instead of scp

I've manually tested this a bit, it's looking legit. We're gonna have to see how it goes in wild.

Notes from the code cave: * I tried to make it possible to `app move` an app on the same server for the purposes of testing 😂 This complicated everything so much that it became impossible to read the code anymore. I have abandoned this for now. * ~~Due to the chaotic nature of what people put on containers, a lot of containers won't be moveable. For example, all the "distroless" containers won't be supported because you can't `sudo cat ...`. I've added this to the `--help` output~~ **update**: it's portable: https://git.coopcloud.tech/toolshed/abra/pulls/636#issuecomment-26612 * Use `rsync` instead of `scp` I've manually tested this a bit, it's looking legit. We're gonna have to see how it goes in wild.
decentral1se merged commit f0e2b012c6 into main 2025-09-01 09:22:10 +00:00
decentral1se deleted branch abra-app-move-continued 2025-09-01 09:22:10 +00:00
Member

Notes from the code cave:

  • I tried to make it possible to app move an app on the same server for the purposes of testing 😂 This complicated everything so much that it became impossible to read the code anymore. I have abandoned this for now.
  • Due to the chaotic nature of what people put on containers, a lot of containers won't be moveable. For example, all the "distroless" containers won't be supported because you can't sudo cat .... I've added this to the --help output
  • Use rsync instead of scp

I've manually tested this a bit, it's looking legit. We're gonna have to see how it goes in wild.

Note in the second point: this is how i Bad it in the beginning but i also ran into bis limitation. It now copies the secret using ssh and cat there so it only needs cat to be installed in the server not in the container

> Notes from the code cave: > > * I tried to make it possible to `app move` an app on the same server for the purposes of testing 😂 This complicated everything so much that it became impossible to read the code anymore. I have abandoned this for now. > * Due to the chaotic nature of what people put on containers, a lot of containers won't be moveable. For example, all the "distroless" containers won't be supported because you can't `sudo cat ...`. I've added this to the `--help` output > * Use `rsync` instead of `scp` > > I've manually tested this a bit, it's looking legit. We're gonna have to see how it goes in wild. Note in the second point: this is how i Bad it in the beginning but i also ran into bis limitation. It now copies the secret using ssh and cat there so it only needs cat to be installed in the server not in the container
Sign in to join this conversation.
No description provided.