ensure repo is up to date before printing status #753

2026-01-15T01:38:17Z

ammaratef45 commented

2026-01-15 01:38:17 +00:00

I need help figuring out how to add unit tests here, when I had this part isolated (passed in the recipe) I couldn't mock Recipe struct, maybe changing the struct into an interface would help with such unit tests?

#737 I need help figuring out how to add unit tests here, when I had this part isolated (passed in the recipe) I couldn't mock Recipe struct, maybe changing the struct into an interface would help with such unit tests?

ammaratef45 added 1 commit 2026-01-15 01:38:18 +00:00

ensure repo is up to date before printing status

continuous-integration/drone/push Build is failing

Details

continuous-integration/drone/pr Build is failing

Details

304ac87cec

decentral1se commented

2026-01-15 09:04:43 +00:00

@ammaratef45 Nice! In a similar vein to #750 (comment) i would abandon unit tests on this particular code path and just wire up an integration test that follows #737 (comment). There are helper functions for manipulating tags: https://git.coopcloud.tech/toolshed/abra/src/branch/main/tests/integration/helpers/git.bash#L6 Good luck!

@ammaratef45 Nice! In a similar vein to https://git.coopcloud.tech/toolshed/abra/pulls/750#issuecomment-29743 i would abandon unit tests on this particular code path and just wire up an integration test that follows https://git.coopcloud.tech/toolshed/abra/issues/737#issuecomment-29811. There are helper functions for manipulating tags: https://git.coopcloud.tech/toolshed/abra/src/branch/main/tests/integration/helpers/git.bash#L6 Good luck!

❤️ 1

ammaratef45 added 1 commit 2026-01-16 22:27:36 +00:00

added integration test

continuous-integration/drone/push Build is failing

Details

182fc41c58

ammaratef45 marked the pull request as ready for review 2026-01-16 22:28:23 +00:00

ammaratef45 commented

2026-01-16 22:30:11 +00:00

Thanks @decentral1se I've followed your advise and this PR is ready to go imo

👍 1

decentral1se approved these changes 2026-01-16 23:05:48 +00:00

decentral1se left a comment

Thanks!

decentral1se merged commit 182fc41c58 into main

2026-01-16 23:05:53 +00:00

decentral1se deleted branch 737

2026-01-16 23:05:53 +00:00

decentral1se commented

2026-01-18 00:18:42 +00:00

@ammaratef45 CI failures: https://build.coopcloud.tech/toolshed/abra/3511/1/7

ammaratef45 commented

2026-01-18 00:29:26 +00:00

Ah rip

-- regular expression does not match output --

regexp : [[:space:]]0

output : 0

 --

I need a regexp that translates to 0 or more white spaces followed by 0 while [[:space:]]0 translates to 1 or more white spaces followed by 0

Will fix it and send a follow-up PR

Ah rip ``` -- regular expression does not match output -- regexp : [[:space:]]0 output : 0 -- ``` I need a regexp that translates to `0 or more white spaces followed by 0` while `[[:space:]]0` translates to `1 or more white spaces followed by 0` Will fix it and send a follow-up PR

❤️ 1

ammaratef45 commented

2026-01-21 05:14:40 +00:00