toolshed/abra
4
3
Fork 21
Code Issues 40 Pull Requests 4 Packages Releases 42 Activity

ensure repo is up to date before printing status #753

Merged
decentral1se merged 2 commits from 737 into main 2026-01-16 23:05:53 +00:00
Conversation 5 Commits 2 Files Changed 3 +23 -1
ammaratef45 commented 2026-01-15 01:38:17 +00:00
Member
Copy Link

#737

I need help figuring out how to add unit tests here, when I had this part isolated (passed in the recipe) I couldn't mock Recipe struct, maybe changing the struct into an interface would help with such unit tests?

#737 I need help figuring out how to add unit tests here, when I had this part isolated (passed in the recipe) I couldn't mock Recipe struct, maybe changing the struct into an interface would help with such unit tests?
ammaratef45 added 1 commit 2026-01-15 01:38:18 +00:00
ensure repo is up to date before printing status
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
304ac87cec
decentral1se commented 2026-01-15 09:04:43 +00:00
Owner
Copy Link

@ammaratef45 Nice! In a similar vein to #750 (comment) i would abandon unit tests on this particular code path and just wire up an integration test that follows #737 (comment). There are helper functions for manipulating tags: https://git.coopcloud.tech/toolshed/abra/src/branch/main/tests/integration/helpers/git.bash#L6 Good luck!

@ammaratef45 Nice! In a similar vein to https://git.coopcloud.tech/toolshed/abra/pulls/750#issuecomment-29743 i would abandon unit tests on this particular code path and just wire up an integration test that follows https://git.coopcloud.tech/toolshed/abra/issues/737#issuecomment-29811. There are helper functions for manipulating tags: https://git.coopcloud.tech/toolshed/abra/src/branch/main/tests/integration/helpers/git.bash#L6 Good luck!
❤️ 1
ammaratef45 added 1 commit 2026-01-16 22:27:36 +00:00
added integration test
Some checks failed
continuous-integration/drone/push Build is failing
Details
182fc41c58
ammaratef45 changed title from WIP: ensure repo is up to date before printing status to ensure repo is up to date before printing status 2026-01-16 22:28:23 +00:00
ammaratef45 commented 2026-01-16 22:30:11 +00:00
Author
Member
Copy Link

Thanks @decentral1se I've followed your advise and this PR is ready to go imo

Thanks @decentral1se I've followed your advise and this PR is ready to go imo
👍 1
decentral1se approved these changes 2026-01-16 23:05:48 +00:00
decentral1se left a comment
Owner
Copy Link

Thanks!

Thanks!
decentral1se merged commit 182fc41c58 into main 2026-01-16 23:05:53 +00:00
decentral1se deleted branch 737 2026-01-16 23:05:53 +00:00
decentral1se commented 2026-01-18 00:18:42 +00:00
Owner
Copy Link

@ammaratef45 CI failures: https://build.coopcloud.tech/toolshed/abra/3511/1/7

@ammaratef45 CI failures: https://build.coopcloud.tech/toolshed/abra/3511/1/7
ammaratef45 commented 2026-01-18 00:29:26 +00:00
Author
Member
Copy Link

Ah rip

-- regular expression does not match output --

regexp : [[:space:]]0

output : 0

 --

I need a regexp that translates to 0 or more white spaces followed by 0 while [[:space:]]0 translates to 1 or more white spaces followed by 0

Will fix it and send a follow-up PR

Ah rip ``` -- regular expression does not match output -- regexp : [[:space:]]0 output : 0 -- ``` I need a regexp that translates to `0 or more white spaces followed by 0` while `[[:space:]]0` translates to `1 or more white spaces followed by 0` Will fix it and send a follow-up PR
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
installer
Everything to do with the install script.
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jade jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moritz notplants p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#753
No description provided.
Delete Branch "737"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?