toolshed/abra
4
3
Fork 21
Code Issues 45 Pull Requests 5 Packages Releases 42 Activity

fix regexp for _remove_tags bats output #756

Merged
decentral1se merged 1 commits from 737 into main 2026-01-26 07:05:54 +00:00
Conversation 5 Commits 1 Files Changed 1 +1 -1
ammaratef45 commented 2026-01-21 05:14:27 +00:00
Member
Copy Link
No description provided.
ammaratef45 added 1 commit 2026-01-21 05:14:28 +00:00
fix regexp for _remove_tags bats output
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is passing
Details
0759be6f8f
decentral1se reviewed 2026-01-21 12:42:15 +00:00
decentral1se left a comment
Owner
Copy Link

@ammaratef45 thanks! did you manage to validate if this fixes the broken tests by running the failing integration tests locally? otherwise i'm afraid we're doing a "merge and hope" which usually results in more work 🙃

@ammaratef45 thanks! did you manage to validate if this fixes the broken tests by running the failing integration tests locally? otherwise i'm afraid we're doing a "merge and hope" which usually results in more work 🙃
ammaratef45 commented 2026-01-21 20:34:32 +00:00
Author
Member
Copy Link

@ammaratef45 thanks! did you manage to validate if this fixes the broken tests by running the failing integration tests locally? otherwise i'm afraid we're doing a "merge and hope" which usually results in more work 🙃

Well, the problem is that the behavior locally is different than the CI system, i get whitespace before the 0 in output locally for some bizarre reason im sure 😅

> @ammaratef45 thanks! did you manage to validate if this fixes the broken tests by running the failing integration tests locally? otherwise i'm afraid we're doing a "merge and hope" which usually results in more work 🙃 Well, the problem is that the behavior locally is different than the CI system, i get whitespace before the 0 in output locally for some bizarre reason im sure 😅
decentral1se commented 2026-01-26 07:05:27 +00:00
Owner
Copy Link

OK, let's merge and hope then 😆 Please check the CI the next days to see if it works... if the issues persists, we'll have to chase it up again. @p4u1 and myself made this attempt to allow the integration tests to be triggered on-demand in a pull request on branches that have int-... in themmmm... i haven't tried this in forever but it might be a way to test this further if required.... i can also give you direct access to the CI server where you can run stuff manually very easily in the same environment (which is what I do)

.drone.yml Lines 94 to 116 in f835b87255
- name: on-demand integration test
image: appleboy/drone-ssh
settings:
host:
- int.coopcloud.tech
username: abra
key:
from_secret: abra_int_private_key
port: 22
command_timeout: 60m
script_stop: true
request_pty: true
script:
- |
wget https://git.coopcloud.tech/toolshed/abra/raw/branch/main/scripts/tests/run-ci-int -O run-ci-int
chmod +x run-ci-int
sh run-ci-int
when:
ref:
- refs/heads/int-*
depends_on:
- make check
- make test

OK, let's merge and hope then 😆 Please check the CI the next days to see if it works... if the issues persists, we'll have to chase it up again. @p4u1 and myself made this attempt to allow the integration tests to be triggered on-demand in a pull request on branches that have `int-...` in themmmm... i haven't tried this in forever but it might be a way to test this further if required.... i can also give you direct access to the CI server where you can run stuff manually very easily in the same environment (which is what I do) https://git.coopcloud.tech/toolshed/abra/src/commit/f835b872559a7a58845675a976486733c90a7a28/.drone.yml#L94-L116
❤️ 1
decentral1se merged commit 1d24107956 into main 2026-01-26 07:05:54 +00:00
decentral1se deleted branch 737 2026-01-26 07:05:54 +00:00
decentral1se commented 2026-01-26 22:04:33 +00:00
Owner
Copy Link

I manually tested the CI, it works, thanks @ammaratef45!

I manually tested the CI, it works, thanks @ammaratef45!
🎉 1
ammaratef45 commented 2026-01-26 23:48:13 +00:00
Author
Member
Copy Link

OK, let's merge and hope then 😆 Please check the CI the next days to see if it works... if the issues persists, we'll have to chase it up again. @p4u1 and myself made this attempt to allow the integration tests to be triggered on-demand in a pull request on branches that have int-... in themmmm... i haven't tried this in forever but it might be a way to test this further if required.... i can also give you direct access to the CI server where you can run stuff manually very easily in the same environment (which is what I do)

.drone.yml Lines 94 to 116 in f835b87255
- name: on-demand integration test
image: appleboy/drone-ssh
settings:
host:
- int.coopcloud.tech
username: abra
key:
from_secret: abra_int_private_key
port: 22
command_timeout: 60m
script_stop: true
request_pty: true
script:
- |
wget https://git.coopcloud.tech/toolshed/abra/raw/branch/main/scripts/tests/run-ci-int -O run-ci-int
chmod +x run-ci-int
sh run-ci-int
when:
ref:
- refs/heads/int-*
depends_on:
- make check
- make test

That's pretty cool, will have to try it out next time I'm touching integ tests

> OK, let's merge and hope then 😆 Please check the CI the next days to see if it works... if the issues persists, we'll have to chase it up again. @p4u1 and myself made this attempt to allow the integration tests to be triggered on-demand in a pull request on branches that have `int-...` in themmmm... i haven't tried this in forever but it might be a way to test this further if required.... i can also give you direct access to the CI server where you can run stuff manually very easily in the same environment (which is what I do) > > https://git.coopcloud.tech/toolshed/abra/src/commit/f835b872559a7a58845675a976486733c90a7a28/.drone.yml#L94-L116 That's pretty cool, will have to try it out next time I'm touching integ tests
🎉 1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
installer
Everything to do with the install script.
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jade jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moritz notplants p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#756
No description provided.
Delete Branch "737"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?