toolshed/organising
toolshed/organising
8
1
Fork 0
Code Issues 120 Pull Requests Releases Activity

abra app backup operates on compose files that are not in use #632

New Issue
Closed
opened 2024-07-24 21:48:38 +00:00 by marlon · 6 comments
marlon commented 2024-07-24 21:48:38 +00:00
Copy Link

abra app backup runs the commands listed under deploy->labels->backupbot* for each compose*.yml file in the directory for a given recipe.

This causes an error when an optional compose file is included in a recipe but is not being used (i.e. it's not referenced in the config).

For example in the nextcloud recipe, compose.mariadb.yml and compose.postgres.yml are both included, and both include backup commands.
Typically only of these databases is enabled, via the configuration. But abra app backup tries to run the backup commands for both mariadb and postgres, and errors out on the one that hasn't been installed.

`abra app backup` runs the commands listed under deploy->labels->backupbot* for each compose*.yml file in the directory for a given recipe. This causes an error when an optional compose file is included in a recipe but is not being used (i.e. it's not referenced in the config). For example in the nextcloud recipe, compose.mariadb.yml and compose.postgres.yml are both included, and both include backup commands. Typically only of these databases is enabled, via the configuration. But `abra app backup` tries to run the backup commands for both mariadb and postgres, and errors out on the one that hasn't been installed.
marlon added the
bug
 label 2024-07-24 21:48:38 +00:00
decentral1se added the
abra
backups
 labels 2024-07-25 21:01:40 +00:00
decentral1se commented 2024-07-25 21:04:58 +00:00
Owner
Copy Link

Hey @marlon 👋 Thanks for raising this. That does seem to be a pretty bad bug. The thing is at the moment is that we're 50%+ through a re-design/implementation of the backup system that uses https://git.coopcloud.tech/coop-cloud/backup-bot-two It would be quite tricky to patch and release the fix atm 🤔

Hey @marlon 👋 Thanks for raising this. That does seem to be a pretty bad bug. The thing is at the moment is that we're 50%+ through a re-design/implementation of the backup system that uses https://git.coopcloud.tech/coop-cloud/backup-bot-two It would be quite tricky to patch and release the fix atm 🤔
moritz commented 2024-07-26 07:55:27 +00:00
Member
Copy Link

Can you provide which abra version and which backup-bot-two version you are using?
The new backupbot version (main branch) fetches the commands only from the running container. If a container is not running it's not able to get the pre/post commands:

backupbot.py Line 134 in cc049b858b
pre_commands[container] = prehook

backupbot.py Line 116 in cc049b858b
services = client.services.list()

client.services.list() is equivalent to docker service ls and lists only running services. Can you run docker service ls and look which services are running? Is there maybe an old zombie container left?

Can you provide which abra version and which backup-bot-two version you are using? The new backupbot version (main branch) fetches the commands only from the running container. If a container is not running it's not able to get the pre/post commands: https://git.coopcloud.tech/coop-cloud/backup-bot-two/src/commit/cc049b858b111b8b399d385f8897a3e604318c20/backupbot.py#L134 https://git.coopcloud.tech/coop-cloud/backup-bot-two/src/commit/cc049b858b111b8b399d385f8897a3e604318c20/backupbot.py#L116 `client.services.list()` is equivalent to `docker service ls` and lists only running services. Can you run `docker service ls` and look which services are running? Is there maybe an old zombie container left?
marlon commented 2024-07-29 15:35:03 +00:00
Author
Copy Link

Can you provide which abra version and which backup-bot-two version you are using?
The new backupbot version (main branch) fetches the commands only from the running container. If a container is not running it's not able to get the pre/post commands:

backupbot.py Line 134 in cc049b858b
pre_commands[container] = prehook

backupbot.py Line 116 in cc049b858b
services = client.services.list()

client.services.list() is equivalent to docker service ls and lists only running services. Can you run docker service ls and look which services are running? Is there maybe an old zombie container left?

Thanks for your attention! I was using abra version 0.9.0-beta-e3a0af5 and not using backup-bot-two, just the abra backup command documented here: https://docs.coopcloud.tech/operators/handbook/#how-do-i-backuprestore-my-app

But thanks to @decentral1se 's note I now understand that abra backup is not currently supported, and the fix is to use backup-bot-two instead. If appropriate I could update the above linked docs to reflect this?

> Can you provide which abra version and which backup-bot-two version you are using? > The new backupbot version (main branch) fetches the commands only from the running container. If a container is not running it's not able to get the pre/post commands: > https://git.coopcloud.tech/coop-cloud/backup-bot-two/src/commit/cc049b858b111b8b399d385f8897a3e604318c20/backupbot.py#L134 > https://git.coopcloud.tech/coop-cloud/backup-bot-two/src/commit/cc049b858b111b8b399d385f8897a3e604318c20/backupbot.py#L116 > `client.services.list()` is equivalent to `docker service ls` and lists only running services. Can you run `docker service ls` and look which services are running? Is there maybe an old zombie container left? Thanks for your attention! I was using abra version 0.9.0-beta-e3a0af5 and not using backup-bot-two, just the `abra backup` command documented here: https://docs.coopcloud.tech/operators/handbook/#how-do-i-backuprestore-my-app But thanks to @decentral1se 's note I now understand that `abra backup` is not currently supported, and the fix is to use backup-bot-two instead. If appropriate I could update the above linked docs to reflect this?
decentral1se commented 2024-07-30 11:31:48 +00:00
Owner
Copy Link

@marlon thx, yeh maybe pointing to anything with issue label "backups" + "bug" and saying we're working on the new version and trying to avoid dealing with backporting fixes atm... something something "try out backup-bot-two? Unsure... it's all a bit unstable atm. i know a couple of collectives are using backup-bot-two a lot so you could get some additional help from the Matrix tech channel 🙏

@marlon thx, yeh maybe pointing to anything with issue label "backups" + "bug" and saying we're working on the new version and trying to avoid dealing with backporting fixes atm... something something "try out `backup-bot-two`? Unsure... it's all a bit unstable atm. i know a couple of collectives are using `backup-bot-two` a lot so you could get some additional help from the Matrix tech channel 🙏
decentral1se commented 2024-08-05 10:24:37 +00:00
Owner
Copy Link

Related coop-cloud/nextcloud#43 (comment)

Related https://git.coopcloud.tech/coop-cloud/nextcloud/issues/43#issuecomment-21286
decentral1se commented 2025-01-03 20:50:40 +00:00
Owner
Copy Link

backup-bot-two is quite stable now, hopefully migrating to that is an acceptable fix for this. The soon (hopefully) to be released abra will also support it. Also, I've opened up a discussion to see what we should do for backup-bot in general: coop-cloud/backup-bot#5 Unsure what more can be done, gonna close this now. Feel free to re-open if there is something to handle!

`backup-bot-two` is quite stable now, hopefully migrating to that is an acceptable fix for this. The soon (hopefully) to be released `abra` will also support it. Also, I've opened up a discussion to see what we should do for `backup-bot` in general: https://git.coopcloud.tech/coop-cloud/backup-bot/issues/5 Unsure what more can be done, gonna close this now. Feel free to re-open if there is something to handle!
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abra
Everything to do with abra
abra-gandi
Abra Gandi plugin
awaiting-feedback
Ping/pong on comms
backups
bug
Something is not working
build
Go build related issues
ci/cd
Getting the robots into the mix
community organising
Opening this thing up
contributing
Contributors stuff
coopcloud.tech
Our main website
democracy
Democratic decision making
design
Design thinking required
documentation
Let's write things together
duplicate
This issue or pull request already exists
enhancement
New feature
finance
Money things
funding
Anything related to grant funding
good first issue
Easy start with development
help wanted
Need some help
installer
Installation related issues
kadabra
performance
Performance related
proposal
Large change which requires feedback & decisin making
question
More information is needed
recipes.coopcloud.tech
Our recipes catalogue
security
Securing our shit
test
Unit or integration test suite
wontfix
This won't be fixed
No Label
abra
backups
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/organising#632
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?