fix(version): semver version ordering #293
No reviewers
Labels
No Label
bug
build
ci/cd
contributing
design
documentation
duplicate
enhancement
help wanted
invalid
meta
question
security
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/abra#293
Loading…
Reference in New Issue
No description provided.
Delete Branch "fix_version_sort"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Solves coop-cloud/organising#427
This fix sorts the recipe versions at the catalogue generation. This way also old abra clients will work correctly after a regeneration of the catalogue. The fix also sorts the versions that are received from the catalogue, so the catalogue entry order is agnostic to the version order, avoiding any implicit implementation assumptions.
Awesome, thanks for picking this up! Question: can we re-use
tagcmp
for the version comparison operations? I'd like to avoid an additional dependecy if possible.354389839c
toc94cc9d38e
I replaced semver with tagcmp. But now I've seen that semver is pulled as indirect dependency anyway. I'm not sure which variant is better.
Aha @moritz righhhht, I forgot 😬 Yeh I'm happy with this as other places in the codebase uses
tagcmp
, so it's probably handy to keep using the same API surface. Merge away imho, thanks!