coop-cloud/abra
coop-cloud
/
abra
5
2
Fork 16
Code Issues Pull Requests 1 Packages Releases 36 Activity

feat: charm logger #428

Merged
decentral1se merged 4 commits from central-charm-log into main 2024-07-07 22:14:24 +00:00
Conversation 0 Commits 4 Files Changed 87 +961 -904
decentral1se commented 2024-07-07 22:10:13 +00:00
Owner
Copy Link

See coop-cloud/organising#422

  • Centralises logger into a single place, so we can refactor/replace/modify simply going forward
  • Uses https://github.com/charmbracelet/log/ which has decent coloured output & automatic caller info

I think it's worth using charmbracelet/log over the default logger for the colour. They seem to be open to other usability features such as https://github.com/charmbracelet/log/issues/118 for coop-cloud/organising#567.

image

See https://git.coopcloud.tech/coop-cloud/organising/issues/422 * Centralises logger into a single place, so we can refactor/replace/modify simply going forward * Uses https://github.com/charmbracelet/log/ which has decent coloured output & automatic caller info I think it's worth using `charmbracelet/log` over the default logger for the colour. They seem to be open to other usability features such as https://github.com/charmbracelet/log/issues/118 for https://git.coopcloud.tech/coop-cloud/organising/issues/567. ![image](/attachments/19cf97ab-585e-4822-99a5-2328d62ba42a)
image.png
28 KiB
🎉 1
decentral1se added 4 commits 2024-07-07 22:10:13 +00:00
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
ef108d63e1
refactor: use central logger
decentral1se merged commit ef108d63e1 into main 2024-07-07 22:14:24 +00:00
decentral1se deleted branch central-charm-log 2024-07-07 22:14:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
build

go build related issues

  
ci/cd

Building things with CI/CD

  
contributing

Dealing with contributing

  
design

UI/UX

  
documentation

Documenting all the things

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
meta

relating to the project or repo itself

  
question

More information is needed

  
security

Security related

  
wontfix

This won't be fixed

No Label
bug
build
ci/cd
contributing
design
documentation
duplicate
enhancement
help wanted
invalid
meta
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/abra#428
No description provided.
Delete Branch "central-charm-log"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?