coop-cloud/collabora
3
1
Fork 2
generated from coop-cloud/example
Code Issues 2 Pull Requests 1 Releases Wiki Activity

Remove nginx from recipe #17

Open
stevensting wants to merge 1 commits from remove-nginx into main
pull from: remove-nginx
merge into: :main
Conversation 2 Commits 1 Files Changed 4
+9 -104
stevensting commented 2026-09-11 18:50:41 +00:00
Owner
Copy Link
Copy Source
<!-- Thank you for doing recipe maintenance work! Please mark all checklist items which are relevant for your changes. Please remove the checklist items which are not relevant for your changes. Feel free to remove this comment. --> * [x] I have deployed and tested my changes * [x] I have [updated relevant versions in `abra.sh`](https://docs.coopcloud.tech/maintainers/upgrade/#updating-versions-in-the-abrash) * [x] I have made my environment variable changes [backwards compatible](https://docs.coopcloud.tech/maintainers/upgrade/#backwards-compatible-environment-variable-changes) * [ ] I have added a [release note entry](https://docs.coopcloud.tech/maintainers/upgrade/#creating-new-release-notes)
stevensting added 1 commit 2026-09-11 18:50:41 +00:00
remove nginx, collabora interfaces directly with traefik
continuous-integration/drone/pr Build is failing
Details
11f199ffb8
stevensting requested review from Apfelwurm 2026-09-11 18:51:03 +00:00
stevensting requested review from devydave 2026-09-12 12:32:28 +00:00
stevensting requested review from carla 2026-09-16 08:07:46 +00:00
stevensting requested review from moritz 2026-09-16 08:07:47 +00:00
stevensting requested review from simon 2026-09-16 08:07:47 +00:00
stevensting commented 2026-09-16 08:09:05 +00:00
Author
Owner
Copy Link
Copy Source

In my tests I had the feeling that this made collabora somewhat faster that with nginx.

In my tests I had the feeling that this made collabora somewhat faster that with nginx.
nginx.conf.tmpl
@@ -57,4 +0,0 @@
# Admin Console websocket
location ^~ /cool/adminws {
moritz commented 2026-09-16 09:59:45 +00:00
Owner
Copy Link
Copy Source

Do you know if there are any security considerations, by removing nginx?

Do you know if there are any security considerations, by removing nginx?
stevensting commented 2026-10-06 11:54:37 +00:00
Author
Owner
Copy Link
Copy Source

@decentral1se you originally added nginx. Do you have an opinion here?

@decentral1se you originally added nginx. Do you have an opinion here?
decentral1se commented 2026-10-06 12:02:47 +00:00
Owner
Copy Link
Copy Source

Can't remember why I even did this, proceed! Thanks for the maintenance work 🙏

Can't remember why I even did this, proceed! Thanks for the maintenance work 🙏
stevensting commented 2026-10-06 12:13:42 +00:00
Author
Owner
Copy Link
Copy Source

from my point of view this should be fine, as collabora is intended to be run directly behind a reverse-proxy.
Maybe we could disable the admin console endpoint with the coolwsd directly or at least make it configureable with a disabled default. What do you think @moritz ?

from my point of view this should be fine, as collabora is intended to be run directly behind a reverse-proxy. Maybe we could disable the admin console endpoint with the coolwsd directly or at least make it configureable with a disabled default. What do you think @moritz ?
moritz commented 2026-10-12 11:31:27 +00:00
Owner
Copy Link
Copy Source

I think it's an good idea to make the admin console configurable with a disabled default. But I'm not sure, what the other endpoints and proxy header options in the nginx configuration are doing exactly, and what would be the consequences without them.

I think it's an good idea to make the admin console configurable with a disabled default. But I'm not sure, what the other endpoints and proxy header options in the nginx configuration are doing exactly, and what would be the consequences without them.
stevensting commented 2026-10-20 08:56:35 +00:00
Author
Owner
Copy Link
Copy Source

Form my point of view all endpoints are non-critical and they should remain open for collabora to work.
^~ /browser static files like css
^~ /hosting/discovery WOPI discovery
^~ /hosting/capabilities info about the server
~ ^/cool/(.*)/ws$ main WOPI endpoint for document editing
~ ^/(c|l)ool downloads etc

The config made ngnix drops everything but the defined endpoints. If we wanted to, we could do it the same for the traefik config, but I would assume that isn't really necessary as collabora is designed to run public facing.
All other config params are already handled by traefik in default config, so no need to add anything.

Form my point of view all endpoints are non-critical and they should remain open for collabora to work. `^~ /browser` static files like css `^~ /hosting/discovery` WOPI discovery `^~ /hosting/capabilities` info about the server `~ ^/cool/(.*)/ws$` main WOPI endpoint for document editing `~ ^/(c|l)ool` downloads etc The config made ngnix drops everything but the defined endpoints. If we wanted to, we could do it the same for the traefik config, but I would assume that isn't really necessary as collabora is designed to run public facing. All other config params are already handled by traefik in default config, so no need to add anything.
Some required checks failed
continuous-integration/drone/pr Build is failing
Details
This pull request has changes conflicting with the target branch.
  • compose.yml
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin remove-nginx:remove-nginx
git checkout remove-nginx
Sign in to join this conversation.
Reviewers
No Reviewers
Apfelwurm
devydave
carla
simon
moritz
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) Apfelwurm appletalk arjan basebuilder BornDeleuze (Born Deleuze) Brooke carla cas (Cassowary) codegod100 coopcloud cyrnel dannygroenewegen (Danny Groenewegen) decentral1se (d1) dede devydave fauno (fauno) flancian Frando hex (Josh Dukes) iexos jade (Jade Ambrose) javielico (Javielico) jjsfunhouse jmakdah2 (Jackie Makdah) joe-irving (Joe Irving) kawaiipunk (KawaiiPunk) knoflook kolaente lambdabundesverband linnealovespie (April) marlon (marlon) mayel mirsal moosemower moritz nicksellen (Nick Sellen) notplants oxaliq (sorrel) p4u1 (p4u1) pau pharaohgraphy (Andrew 🐦‍🔥❤️‍🔥✴️) PhiNatalie renovate-bot (Comrade Renovate Bot) ripclap rix rscmbbng sef (sef) simon sixsmith (Sixsmith) stevensting (stevensting) tobias trav (Trav Fryer) val (val (he/him)) vaznasty virtualboys wolcen (Chris Thompson) wykwit xynosis yksflip
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/collabora#17