Deployment fails because abra thinks comments are part of the network names #11

New Issue

3wordchant · 2023-10-02T18:33:23Z

3wordchant commented

2023-10-02 18:33:23 +00:00

FATA[0005] network "lists-mail_gfsc_studio_default # mailu network" is declared as external, but could not be found. You need to create a swarm-scoped network before the stack is deployed

Maybe relevant to #6 (should we just kill mailu integration with fire)

`FATA[0005] network "lists-mail_gfsc_studio_default # mailu network" is declared as external, but could not be found. You need to create a swarm-scoped network before the stack is deployed ` Maybe relevant to #6 (should we just kill mailu integration with fire)

decentral1se referenced this issue from coop-cloud/organising

2023-10-03 07:23:29 +00:00

Drop unknown comments from .env/.yml #496

decentral1se commented

2023-10-03 07:23:43 +00:00

(should we just kill mailu integration with fire)

Yes, probably 😆

FATA[0005] network "lists-mail_gfsc_studio_default # mailu network"

I'll try get this fixed in abra, coop-cloud/organising#496

> (should we just kill mailu integration with fire) Yes, probably 😆 > FATA[0005] network "lists-mail_gfsc_studio_default # mailu network" I'll try get this fixed in `abra`, https://git.coopcloud.tech/coop-cloud/organising/issues/496

❤️ 1

3wordchant commented

2023-10-03 07:36:08 +00:00

Yes, probably 😆

3 hours fighting docker networking yesterday for a deployment which doesn't need 90% of Mailu's features, and I'm increasingly agreeing...

> Yes, probably 😆 3 hours fighting docker networking yesterday for a deployment which doesn't need 90% of Mailu's features, and I'm increasingly agreeing...

👀 1

decentral1se commented

2023-10-03 10:46:12 +00:00

@3wordchant can you give an example of how this comment is getting carried over? Is it contained in the .env file or is it in the .yml file?

I tried to reproduce in an integration test but got the following (abra: 54dc696c69b7eb9b1240b172fd0a792ac51befe8):

diff --git a/.env.sample b/.env.sample
index 0f0739d..eb1b58c 100644
--- a/.env.sample
+++ b/.env.sample
@@ -9,6 +9,9 @@ COMPOSE_FILE="compose.yml"

 LETS_ENCRYPT_ENV=production

+NET_WITH_COMMENT=foo # bar
+NET_WITH_COMMENT_TWO=baz # bing=bong
+
 SECRET_TEST_PASS_ONE_VERSION=v1
 SECRET_TEST_PASS_TWO_VERSION=v1 # length=10
 #SECRET_EXTRA_PASS_VERSION=v1

And then:

---
version: "3.8"

services:
  app:
    networks:
      - net_comment_one
      - net_comment_two

networks:
  net_comment_one:
    external: true
    name: ${NETWORK_WITH_COMMENT}
  net_comment_two:
    external: true
    name: ${NETWORK_WITH_COMMENT_TWO}

And got the following:

FATA[0004] network "net_comment_one" is declared as external, but could not be found. You need to create a swarm-scoped network before the stack is deployed

Where the comment appears to be dropped?

@3wordchant can you give an example of how this comment is getting carried over? Is it contained in the `.env` file or is it in the `.yml` file? I tried to reproduce in an integration test but got the following (`abra`: `54dc696c69b7eb9b1240b172fd0a792ac51befe8`): ```diff diff --git a/.env.sample b/.env.sample index 0f0739d..eb1b58c 100644 --- a/.env.sample +++ b/.env.sample @@ -9,6 +9,9 @@ COMPOSE_FILE="compose.yml" LETS_ENCRYPT_ENV=production +NET_WITH_COMMENT=foo # bar +NET_WITH_COMMENT_TWO=baz # bing=bong + SECRET_TEST_PASS_ONE_VERSION=v1 SECRET_TEST_PASS_TWO_VERSION=v1 # length=10 #SECRET_EXTRA_PASS_VERSION=v1 ``` And then: ```yaml --- version: "3.8" services: app: networks: - net_comment_one - net_comment_two networks: net_comment_one: external: true name: ${NETWORK_WITH_COMMENT} net_comment_two: external: true name: ${NETWORK_WITH_COMMENT_TWO} ``` And got the following: ``` FATA[0004] network "net_comment_one" is declared as external, but could not be found. You need to create a swarm-scoped network before the stack is deployed ``` Where the comment appears to be dropped?

decentral1se referenced this issue from coop-cloud/organising

2023-10-03 10:46:37 +00:00

Drop unknown comments from .env/.yml #496

decentral1se commented

2023-10-09 12:46:24 +00:00

Should be solved in coop-cloud/abra#371 🙏

Should be solved in https://git.coopcloud.tech/coop-cloud/abra/pulls/371 🙏

Sign in to join this conversation.