coop-cloud/traefik
7
1
Fork 12
Code Issues 11 Pull Requests Releases Wiki Activity

add MAINTAINERS.md #61

Merged
p4u1 merged 3 commits from maintainers into master 2025-11-20 17:07:42 +00:00
Conversation 11 Commits 3 Files Changed 2 +27 -1
p4u1 commented 2025-10-31 16:14:26 +00:00
Owner
Copy Link

This is just a proposal, please comment or propose changes :)

This is just a proposal, please comment or propose changes :)
❤️ 3
p4u1 added 1 commit 2025-10-31 16:14:27 +00:00
add MAINTAINERS.md
Some checks failed
continuous-integration/drone/pr Build is failing
Details
4ea14d260a
p4u1 reviewed 2025-10-31 16:15:21 +00:00
MAINTAINERS.md Outdated
@ -0,0 +4,4 @@
## Maintainers
- @p4u1 [Klasse & Methode](https://klasse-methode.it)
p4u1 commented 2025-10-31 16:15:21 +00:00
Author
Owner
Copy Link

Add your self here :)

Add your self here :)
decentral1se commented 2025-10-31 18:32:16 +00:00
Owner
Copy Link

Maybe we can be more explicit and say that @p4u1is the Gitea handle?

Maybe we can be more explicit and say that `@p4u1`is the Gitea handle?
p4u1 commented 2025-11-05 14:31:59 +00:00
Author
Owner
Copy Link

I have linked my gitea profile now where I linked to matrix and co.

I have linked my gitea profile now where I linked to matrix and co.
decentral1se marked this conversation as resolved
decentral1se requested review from 3wordchant 2025-10-31 16:41:00 +00:00
decentral1se requested review from cas 2025-10-31 16:41:00 +00:00
decentral1se reviewed 2025-10-31 18:37:57 +00:00
decentral1se left a comment
Owner
Copy Link

tysm 🙏

tysm 🙏
MAINTAINERS.md Outdated
@ -0,0 +1,25 @@
# Traefik Recipe Maintenance
Only recipe maintainers can push to main / merge pull requests. This is to ensure a certain quality / consistency, that others can rely on.
decentral1se commented 2025-10-31 18:33:47 +00:00
Owner
Copy Link

I would just go straight for "only merge when reviewed by another" workflow. Pushing to main is cool and all but we all make mistakes and if we do want stability, we need more eyeballs before a change lands. Idk if this is controversial but while we're here.... 🤸

I would just go straight for "only merge when reviewed by another" workflow. Pushing to main is cool and all but we all make mistakes and if we do want stability, we need more eyeballs before a change lands. Idk if this is controversial but while we're here.... 🤸
👍 1
decentral1se marked this conversation as resolved
MAINTAINERS.md Outdated
@ -0,0 +8,4 @@
## Maintainer Responsibilities
A recipe maintainer has the following responsibilities:
decentral1se commented 2025-10-31 18:36:46 +00:00
Owner
Copy Link

Should we add the following?

Has renovate enabled for automatic update PRs (so that becomes standard). We might need to document how to update / merge these PRs with label changes.

Is not responsible for solving the issues of others (if it falls outside of update work) but is responsible to triage the issue, e.g. "a fix would look like this, PRs welcome, byeeeee".

Should we add the following? Has renovate enabled for automatic update PRs (so that becomes standard). We might need to document how to update / merge these PRs with label changes. Is not responsible for solving the issues of others (if it falls outside of update work) but is responsible to triage the issue, e.g. "a fix would look like this, PRs welcome, byeeeee".
decentral1se marked this conversation as resolved
MAINTAINERS.md Outdated
@ -0,0 +17,4 @@
## Merge rules
A pull request can be merged if it is approved by at least one maintainer.
A maintainer can push directly to main for small changes and should make a pull request for larger changes like major updates.
decentral1se commented 2025-10-31 18:37:44 +00:00
Owner
Copy Link

I'm fine with it but I'd prefer to abolish "push to main" for stability purposes.

See #61 (comment).

I'm fine with it but I'd prefer to abolish "push to main" for stability purposes. See https://git.coopcloud.tech/coop-cloud/traefik/pulls/61#issuecomment-28308.
👍 1
decentral1se marked this conversation as resolved
3wordchant commented 2025-11-04 17:21:27 +00:00
Owner
Copy Link

Tiny drive-by comment that, as well as this awesome stuff, it'd be great to reflect this in README.md as well. I did my best to interpret the Resolution for coop-cloud/mastodon here: 23a71ea65b

Tiny drive-by comment that, as well as this awesome stuff, it'd be great to reflect this in `README.md` as well. I did my best to interpret the Resolution for coop-cloud/mastodon here: https://git.coopcloud.tech/coop-cloud/mastodon/commit/23a71ea65b6368ecd26f0a905c7cd7bc9cd42478
👍 2
p4u1 added 1 commit 2025-11-04 17:54:54 +00:00
update
Some checks failed
continuous-integration/drone/pr Build is failing
Details
a01ec10d15
p4u1 commented 2025-11-05 14:32:35 +00:00
Author
Owner
Copy Link

I have pushed an update and tried to include @decentral1se and @3wordchant suggestions

I have pushed an update and tried to include @decentral1se and @3wordchant suggestions
decentral1se approved these changes 2025-11-06 09:20:24 +00:00
decentral1se left a comment
Owner
Copy Link

👏

I'm still worried that dealing with doing update work won't happen on time without mandating #61 (comment) but in practice, I guess people will figure it out.

Thanks!

👏 I'm still worried that dealing with doing update work won't happen on time without mandating https://git.coopcloud.tech/coop-cloud/traefik/pulls/61#issuecomment-28309 but in practice, I guess people will figure it out. Thanks!
p4u1 added 1 commit 2025-11-06 09:54:10 +00:00
Update MAINTENANCE.md
Some checks failed
continuous-integration/drone/pr Build is failing
Details
3ae4d8f889
p4u1 commented 2025-11-06 09:54:43 +00:00
Author
Owner
Copy Link

@decentral1se I made another commit, that should resolve your renovate comment: 3ae4d8f889

@decentral1se I made another commit, that should resolve your renovate comment: https://git.coopcloud.tech/coop-cloud/traefik/commit/3ae4d8f889e1499a1a78b6d02729784d0d81f08c
❤️ 1
pharaohgraphy commented 2025-11-06 10:36:08 +00:00
Owner
Copy Link

First of all, love this! 💟
My only Q: why are the expectations here wildly off from the resolution doc?

E.g.

Security issues in the recipe must be patched within one month of discovery

I think a month is too long, but is a same-day turnaround realistic?
I'm keen to hear what y'all think 😊

First of all, love this! 💟 My only Q: why are the expectations here wildly off from the [resolution doc](https://docs.coopcloud.tech/federation/resolutions/passed/025/)? E.g. > Security issues in the recipe must be patched within one month of discovery I think a month is too long, but is a same-day turnaround realistic? I'm keen to hear what y'all think 😊
👀 1
3wordchant commented 2025-11-06 18:36:19 +00:00
Owner
Copy Link

My only Q: why are the expectations here wildly off from the resolution doc?

@pharaohgraphy I see Resolution 025 as establishing a minimum; personally it seems fine if recipe maintainers want to commit (haha) to higher standards above those.

> My only Q: why are the expectations here wildly off from the resolution doc? @pharaohgraphy I see Resolution 025 as establishing a minimum; personally it seems fine if recipe maintainers want to commit (haha) to higher standards above those.
👍 2
Apfelwurm commented 2025-11-07 23:42:11 +00:00
Owner
Copy Link

First of all, love this! 💟
My only Q: why are the expectations here wildly off from the [resolution doc]

I think it is a good idea to set up the expectations high for such a critical piece of software like traefik :)

I think a month is too long, but is a same-day turnaround realistic?

My take on this is, that as soon as we implement renovate, it is really only one click (or api call) for any one of the maintainers to merge security critical updates and i guess therefore we just have to make sure that there are enough people taking on those critical recipes. No matter of how we set our expectations, it would be pretty bad if one of the most exposed services in our ecosystem is exploitable for longer than it needs to be. But its tbd how that works out in practice, as i know that i'm not having the greatest consistency in chore management :D

> First of all, love this! 💟 > My only Q: why are the expectations here wildly off from the [resolution doc] I think it is a good idea to set up the expectations high for such a critical piece of software like traefik :) > I think a month is too long, but is a same-day turnaround realistic? My take on this is, that as soon as we implement renovate, it is really only one click (or api call) for any one of the maintainers to merge security critical updates and i guess therefore we just have to make sure that there are enough people taking on those critical recipes. No matter of how we set our expectations, it would be pretty bad if one of the most exposed services in our ecosystem is exploitable for longer than it needs to be. But its tbd how that works out in practice, as i know that i'm not having the greatest consistency in chore management :D
🎉 1
benjaminlyng commented 2025-11-19 05:52:48 +00:00
First-time contributor
Copy Link

As a coopcloud noob I would really appreciate this as a way to know what to expect from recipe-upgrades. And also as a way to know what would be required as a maintainer.

My only concern would be that this should apply to all recipes, and because of this it might be more efficient to put this in coopcloud docs or some other more central place. Not to say this shouldn't be merged, just a thought.

As a coopcloud noob I would really appreciate this as a way to know what to expect from recipe-upgrades. And also as a way to know what would be required as a maintainer. My only concern would be that this should apply to all recipes, and because of this it might be more efficient to put this in coopcloud docs or some other more central place. Not to say this shouldn't be merged, just a thought.
👍 1
p4u1 commented 2025-11-20 17:07:26 +00:00
Author
Owner
Copy Link

I think I addressed all actionable comments. I will just merge now and we will se how it will go from here. Everyone is welcome to add yourself as a maintainer and also update the maintenance document :)

I think I addressed all actionable comments. I will just merge now and we will se how it will go from here. Everyone is welcome to add yourself as a maintainer and also update the maintenance document :)
🎉 1
p4u1 merged commit 268316cc83 into master 2025-11-20 17:07:42 +00:00
p4u1 deleted branch maintainers 2025-11-20 17:07:42 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
3wordchant
cas
decentral1se
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud cyrnel decentral1se fauno flancian Frando iexos javielico jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband marlon mayel mirsal moritz nicksellen notplants p4u1 pau pharaohgraphy renovate-bot ripclap rix rscmbbng sef simon sixsmith stevensting tobias trav val virtualboys wolcen wykwit xynosis yksflip
No Assignees
6 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/traefik#61
No description provided.
Delete Branch "maintainers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?