Add Cloudflare as DNS provider #103

Merged
decentral1se merged 4 commits from Zigzagill/traefik:add-cloudflare-dns into master 2026-05-16 23:37:49 +00:00
Member
<!-- Thank you for doing recipe maintenance work! Please mark all checklist items which are relevant for your changes. Please remove the checklist items which are not relevant for your changes. Feel free to remove this comment. --> * [x] I have deployed and tested my changes LetsEncrypt challenges passed * [x] I have [updated relevant versions in `abra.sh`](https://docs.coopcloud.tech/maintainers/upgrade/#updating-versions-in-the-abrash) No relevant versions to update * [x] I have made my environment variable changes [backwards compatible](https://docs.coopcloud.tech/maintainers/upgrade/#backwards-compatible-environment-variable-changes) Only new env vars were added * [ ] I have added a [release note entry](https://docs.coopcloud.tech/maintainers/upgrade/#creating-new-release-notes) Unsure if this is necessary but I'm happy to add notes if we want them 😄
Zigzagill added 3 commits 2026-05-15 04:18:14 +00:00
decentral1se requested review from javielico 2026-05-15 09:00:01 +00:00
decentral1se requested review from moritz 2026-05-15 09:00:03 +00:00
decentral1se requested review from p4u1 2026-05-15 09:00:03 +00:00
decentral1se reviewed 2026-05-15 09:05:24 +00:00
decentral1se left a comment
Owner

One minor comment but otherwise, LGTM.

I can't test this myself.

Thanks for the PR!

One minor comment but otherwise, LGTM. I can't test this myself. Thanks for the PR!
.env.sample Outdated
@ -89,0 +92,4 @@
## abra app secret insert {myapp.example.coop} cf_api_key v1 "<CLOUDFLARE_API_KEY>"
## cf_api_key is an account API key from Cloudflare that has DNS read + edit permission
#COMPOSE_FILE="$COMPOSE_FILE:compose.cloudflare.yml"
#SECRET_CLOUDFLARE_EMAIL_VERSION=v1 # generated=false
Owner

I just realise it's generate=false and we have no docs for this 😆

generateRaw, ok := modifierValues["generate"]

Although, I've seen people using generated=false but does it work?

I just realise it's `generate=false` and we have no docs for this 😆 https://git.coopcloud.tech/toolshed/abra/src/commit/8dbde3d15869d1eda0bbb71c4e8c43dfe092e5ff/pkg/secret/secret.go#L193 Although, I've seen people using `generated=false` but does it work?
Author
Member

Aha! You're 100% correct. Just tested, generated still threw an error for "secret not generated", generate allowed me to insert the secret without needing one on the server already 😄

I'm 99% sure the generate=false flag should be added to all of the other DNS provider secrets. I'd be happy to open a separate PR for that as well!

Aha! You're 100% correct. Just tested, `generated` still threw an error for "secret not generated", `generate` allowed me to insert the secret without needing one on the server already 😄 I'm 99% sure the `generate=false` flag should be added to all of the other DNS provider secrets. I'd be happy to open a separate PR for that as well!
Owner

Thanks @Zigzagill, a fix PR for the other DNS providers would be excellent 🙏

Thanks @Zigzagill, a fix PR for the other DNS providers would be excellent 🙏
decentral1se marked this conversation as resolved
Zigzagill added 1 commit 2026-05-15 20:03:42 +00:00
generated -> generate
Some checks failed
continuous-integration/drone/pr Build is failing
fbe027dff1
p4u1 approved these changes 2026-05-16 07:56:38 +00:00
decentral1se approved these changes 2026-05-16 23:37:40 +00:00
decentral1se merged commit 25cf7862ed into master 2026-05-16 23:37:49 +00:00
Sign in to join this conversation.
No Label
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/traefik#103
No description provided.