coop-cloud/traefik
6
2
Fork 19
Code Issues 15 Pull Requests 5 Releases Wiki Activity

proposal for merge policy and maintainer roles #138

Open
moritz wants to merge 2 commits from MAINTENANCE into master
pull from: MAINTENANCE
merge into: :master
Conversation 3 Commits 2 Files Changed 1
+72 -6
moritz commented 2026-08-31 18:32:35 +00:00
Owner
Copy Link
Copy Source

following this discussion: https://matrix.to/#/!DfXPgKLoYCvjHithgS:autonomic.zone/$NiexG16Hr0caSszF25MIyurY4qQzAz1uBdsKNSXVAcU?via=autonomic.zone&via=matrix.org&via=pub.solar

following this discussion: https://matrix.to/#/!DfXPgKLoYCvjHithgS:autonomic.zone/$NiexG16Hr0caSszF25MIyurY4qQzAz1uBdsKNSXVAcU?via=autonomic.zone&via=matrix.org&via=pub.solar
moritz added 1 commit 2026-08-31 18:32:37 +00:00
docs: define merge policy and maintainer roles
continuous-integration/drone/pr Build is failing
Details
e0c0bf35d7
p4u1 reviewed 2026-09-01 13:01:14 +00:00
MAINTENANCE.md
@@ -25,0 +40,4 @@
| Security fix | No, can be merged immediately |
| Regular update | No, after a review window of about one week |
| Feature, extension or change of the default configuration | Yes, always |
| Small change that can't break the recipe | No |
p4u1 commented 2026-09-01 13:01:14 +00:00
Owner
Copy Link
Copy Source

Can you elaborate on why you want to merge those changes directly? While looking through the Definition oft small changes they do not seem to be very urgent. I think I would prefer to not make a distinction between feature and small change

Can you elaborate on why you want to merge those changes directly? While looking through the Definition oft small changes they do not seem to be very urgent. I think I would prefer to not make a distinction between feature and small change
moritz commented 2026-09-01 14:25:39 +00:00
Author
Owner
Copy Link
Copy Source

Because often it's very annoying to wait for approval for such small changes.

  • a new abra.sh function: it doesn't break anything for other but for you it might be urgent to fix something. And if an abra.sh command also calls another abra.sh command it's important that it got released, else it could fail or lead o strange behaviour.
  • changes to the README.md: depends on what is changed. If you just fix some typos, an review is just a waste of time
  • Sometimes tests behave differently in the real test environment as local. Fixing a CI pipeline can be a process of try&error. And if you have automerge active these tests are relevant to get renovate to work again.
  • configuring renovate: same as above, renovate only reads it's configuration from main, therefore a merge is the only way to test configuration fixes.
Because often it's very annoying to wait for approval for such small changes. - a new `abra.sh` function: it doesn't break anything for other but for you it might be urgent to fix something. And if an abra.sh command also calls another abra.sh command it's important that it got released, else it could fail or lead o strange behaviour. - changes to the [README.md](./README.md): depends on what is changed. If you just fix some typos, an review is just a waste of time - Sometimes tests behave differently in the real test environment as local. Fixing a CI pipeline can be a process of try&error. And if you have automerge active these tests are relevant to get renovate to work again. - configuring renovate: same as above, renovate only reads it's configuration from main, therefore a merge is the only way to test configuration fixes.
p4u1 reviewed 2026-09-01 13:01:57 +00:00
MAINTENANCE.md
@@ -6,0 +11,4 @@
[README.md](./README.md), are members of the
[traefik maintainers team](https://git.coopcloud.tech/org/coop-cloud/teams/traefik-maintainers)
and fulfil the responsibilities described below.
- **Contributors with merge access** Trusted people can open pull requests and merge them
p4u1 commented 2026-09-01 13:01:57 +00:00
Owner
Copy Link
Copy Source

For transparency it would be nice yo also add mergers to the readme

For transparency it would be nice yo also add mergers to the readme
moritz marked this conversation as resolved
p4u1 reviewed 2026-09-01 13:03:00 +00:00
p4u1 left a comment
Owner
Copy Link
Copy Source

Nice, thanks for opening this and pushing this discussion! 🙏

Nice, thanks for opening this and pushing this discussion! 🙏
moritz added 1 commit 2026-09-01 14:28:23 +00:00
docs: list contributors in the readme
continuous-integration/drone/pr Build is failing
Details
e82db59a6c
Some required checks failed
continuous-integration/drone/pr Build is failing
Details
You are not authorized to merge this pull request.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin MAINTENANCE:MAINTENANCE
git checkout MAINTENANCE
Sign in to join this conversation.
Reviewers
No Reviewers
p4u1
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) BornDeleuze Brooke carla cas (Cassowary) coopcloud decentral1se (d1) fauno (fauno) javielico (Javielico) jjsfunhouse kawaiipunk (KawaiiPunk) knoflook moosemower moritz notplants oxaliq (sorrel) p4u1 renovate-bot (Comrade Renovate Bot) simon stevensting trav (Trav Fryer) yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/traefik#138