Nice looks good. Cool bonus to have default development and production settings too. And we can continue the conversation about whether to also use figment for other peach configurations in the…
hmm I'm now also wondering how this DISABLE_ROCKET_AUTH config, and our general PeachCloud config.yml should interact. Perhaps we should have One Config.yml To Rule Them All.
I think we were…
@glyph nice, the code in RequestGuard looks exactly how I imagined it would with the if/else.
A couple possible changes to consider:
- use Rocket configs instead of Env variables directly. And…
LG
a lil styling sometimes slips in, I understand
glad to see more code abstracted and less duplication
Looks good to me. Thanks for fixing the change password title.
The tests that test .post routes passing arguments, and .get routes which make complicated calls to retrieve data, seem more…
Re-exporting individual types or functions is generally discouraged when the dependency from which you're exporting is not under your control. In that case, it is better to re-export the entire…
Ah this is re-export thing sounds perfect for this case, thanks for explaining it.
Also had a good call with Alex which helped give more context on sbotcli, and also raised some questions. We…
The problem is one of time and skill. Who can / will modify the Go code to be compatible with static compilation? How long will that take? Would we rather delay the release of PeachPub (might be…
But it's not just returning general data structures, right? It seemed like your intention was to make it super convenient by grouping the results of various sbot calls into more complex structures.…