feat: add config-sets support #8
Reference in New Issue
Block a user
No description provided.
Delete Branch "eCommons/alakazam:config-sets"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Adds support for a config-sets.yml file at the root path where named bundles
of app configurations (env, hooks, secrets) can be defined and activated
per-instance or per-group, eliminating duplication across instance configs.
See #3
🚀🚀🚀 this feature we were missing a lot!
I already created the kolli-cloud config set:
b8243be801The only thing whats missing in this PR are the docs in the Readme, how to use the config-set or an reference to the example file, everything else looks perfect.
@ -237,0 +280,4 @@config_set_app_config = config_set_app_configs.get(app) or {}instance_app_config = instance_apps[app] or {}# Priority: group < config-set < instancemerged_config[app] = merge_dict(merge_dict(group_app_config, config_set_app_config), instance_app_config)I really like how you structured the code in this function. This makes it much more readable and expandable.
@ -281,2 +323,4 @@dict: A dictionary with domains as keys and their respective merged configurations as values."""if config_sets is None:config_sets = {}These lines are redundant, as they are set in
merge_instance_configsas well and only used inmerge_instance_configs.