coop-cloud/authentik
coop-cloud/authentik
1
2
Fork 4
Code Issues 1 Pull Requests 1 Projects Releases Wiki Activity

Custom CSS in volume #9

Merged
3wordchant merged 4 commits from custom-css-volume into main 2025-01-07 15:16:21 +00:00
Conversation 2 Commits 4 Files Changed 4 +27
3wordchant commented 2024-12-24 18:31:18 +00:00
Owner
Copy Link

This PR adds an optional compose file, compose.css-volume.yml, which allows hosters to store a complete custom.css file.

This PR adds an optional compose file, `compose.css-volume.yml`, which allows hosters to store a complete `custom.css` file.
moritz was assigned by 3wordchant 2024-12-24 18:31:18 +00:00
3wordchant added 3 commits 2024-12-24 18:31:19 +00:00
decentral1se reviewed 2024-12-25 09:09:50 +00:00
decentral1se left a comment
Owner
Copy Link

💫

💫
.env.sample Outdated
@ -50,3 +50,1 @@
COPY_ASSETS="flow_background.jpg|app:/web/dist/assets/images/"
COPY_ASSETS="$COPY_ASSETS icon_left_brand.svg|app:/web/dist/assets/icons/"
COPY_ASSETS="$COPY_ASSETS icon.png|app:/web/dist/assets/icons/"
## custom css and assets
decentral1se commented 2024-12-25 09:07:34 +00:00
Owner
Copy Link

Requires some release notes for this change in behaviour?

Requires some release notes for this change in behaviour?
3wordchant commented 2025-01-03 02:32:30 +00:00
Author
Owner
Copy Link

I cannot remember why these were commented out, again I don't think it will affect existing deployments but unless @knoflook remembers more context I say we just revert the commenting-out change.

I cannot remember why these were commented out, again I don't think it will affect existing deployments but unless @knoflook remembers more context I say we just revert the commenting-out change.
👍 1
decentral1se marked this conversation as resolved
compose.css-volume.yml
@ -0,0 +3,4 @@
services:
app:
user: root
decentral1se commented 2024-12-25 09:09:13 +00:00
Owner
Copy Link

Not sure if this changes the attack surface but in case it does, might be worth signalling in release notes and/or docs that a user: root is introduced into the stack deployment? Might be a consideration point since it's usually a central point of infra.

Not sure if this changes the attack surface but in case it does, might be worth signalling in release notes and/or docs that a `user: root` is introduced into the stack deployment? Might be a consideration point since it's usually a central point of infra.
3wordchant commented 2025-01-03 02:31:38 +00:00
Author
Owner
Copy Link

I don't think it changes anything about existing deployments, unless someone opts-in to the extra .yml file.

It's hard for me to imagine how there could be a security hole in either cp, or su, but I don't claim to be an expert.

Happy to add a comment in .env.sample to warn about this, either way.

I don't think it changes anything about existing deployments, unless someone opts-in to the extra `.yml` file. It's hard for me to imagine how there could be a security hole in either `cp`, or `su`, but I don't claim to be an expert. Happy to add a comment in `.env.sample` to warn about this, either way.
🎉 1
decentral1se marked this conversation as resolved
3wordchant commented 2025-01-03 02:32:48 +00:00
Author
Owner
Copy Link

Tysm for the review @decentral1se !

Tysm for the review @decentral1se !
❤️ 1
3wordchant added 1 commit 2025-01-07 15:16:06 +00:00
3wordchant merged commit 344db235b0 into main 2025-01-07 15:16:21 +00:00
3wordchant deleted branch custom-css-volume 2025-01-07 15:16:21 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud decentral1se fauno flancian Frando iexos javielico kawaiipunk knoflook lambdabundesverband mac-chaffee marlon mayel mirsal moritz nicksellen notplants p4u1 pau renovate-bot rix sef simon stevensting tobias trav val virtualboys wolcen wykwit xynosis yksflip
No Assignees moritz
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/authentik#9
No description provided.
Delete Branch "custom-css-volume"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?