Custom CSS in volume #9

2024-12-24T18:31:18Z

3wordchant commented

2024-12-24 18:31:18 +00:00

This PR adds an optional compose file, compose.css-volume.yml, which allows hosters to store a complete custom.css file.

This PR adds an optional compose file, `compose.css-volume.yml`, which allows hosters to store a complete `custom.css` file.

moritz was assigned by 3wordchant

2024-12-24 18:31:18 +00:00

3wordchant added 3 commits 2024-12-24 18:31:19 +00:00

Work towards custom CSS in volume 03797a34db

don't create a new volume fc846af1e3

update .env.sample and drop unused volume e2a8f2340f

decentral1se reviewed 2024-12-25 09:09:50 +00:00

decentral1se left a comment

💫

.env.sample Outdated

						
				@@ -50,3 +50,1 @@

				COPY_ASSETS="flow_background.jpg|app:/web/dist/assets/images/"

				COPY_ASSETS="$COPY_ASSETS icon_left_brand.svg|app:/web/dist/assets/icons/"

				COPY_ASSETS="$COPY_ASSETS icon.png|app:/web/dist/assets/icons/"

				## custom css and assets

decentral1se commented

2024-12-25 09:07:34 +00:00

Requires some release notes for this change in behaviour?

3wordchant commented

2025-01-03 02:32:30 +00:00

I cannot remember why these were commented out, again I don't think it will affect existing deployments but unless @knoflook remembers more context I say we just revert the commenting-out change.

👍 1

decentral1se marked this conversation as resolved

compose.css-volume.yml

						
				@@ -0,0 +3,4 @@

				services:

				  app:

				    user: root

decentral1se commented

2024-12-25 09:09:13 +00:00

Not sure if this changes the attack surface but in case it does, might be worth signalling in release notes and/or docs that a user: root is introduced into the stack deployment? Might be a consideration point since it's usually a central point of infra.

Not sure if this changes the attack surface but in case it does, might be worth signalling in release notes and/or docs that a `user: root` is introduced into the stack deployment? Might be a consideration point since it's usually a central point of infra.

3wordchant commented

2025-01-03 02:31:38 +00:00

I don't think it changes anything about existing deployments, unless someone opts-in to the extra .yml file.

It's hard for me to imagine how there could be a security hole in either cp, or su, but I don't claim to be an expert.

Happy to add a comment in .env.sample to warn about this, either way.

I don't think it changes anything about existing deployments, unless someone opts-in to the extra `.yml` file. It's hard for me to imagine how there could be a security hole in either `cp`, or `su`, but I don't claim to be an expert. Happy to add a comment in `.env.sample` to warn about this, either way.

🎉 1

decentral1se marked this conversation as resolved