Building #3

Merged
sixsmith merged 9 commits from building into main 2026-08-27 11:36:21 +00:00
Owner
No description provided.
Brooke added 9 commits 2026-08-20 22:56:49 +00:00
forgor it's gitea not forgejo
Build And Publish Container / build-latest (push) Failing after 38s
dbd20fd75a
remove non relevant socket proxy entry
Build And Publish Container / build-latest (push) Failing after 14s
77a917c0dd
change auth url
Build And Publish Container / build-latest (push) Successful in 1m57s
99a62a20ea
init manual build file, currently just a copy, testing short SHA for image names
Build And Publish Container / build-latest (push) Successful in 1m47s
61e54b958f
remove manual build, merge into singular tag-build yaml file.
Build And Publish Container / build-latest (push) Failing after 3m16s
6782b150bd
Brooke requested review from sixsmith 2026-08-20 23:10:45 +00:00
sixsmith approved these changes 2026-08-21 16:13:46 +00:00
sixsmith left a comment
Member

Looks good overall with some comments. Thanks for working on this!

Looks good overall with some comments. Thanks for working on this!
@@ -0,0 +17,4 @@
- name: Get short commit SHA
id: vars
run: |
calculatedSha=$(git rev-parse --short ${{ github.sha }})
Member

Is github.sha supposed to be available in this context?

Is `github.sha` supposed to be available in this context?
sixsmith marked this conversation as resolved
@@ -0,0 +27,4 @@
else
TAG="${{ gitea.ref_name }}"
fi
echo "RELEASE_TAG=$TAG" >> $GITHUB_ENV
Member

Same here as above, is $GITHUB_ENV going to set env.RELEASE_TAG in a non-GitHub context?

Same here as above, is `$GITHUB_ENV` going to set `env.RELEASE_TAG` in a non-GitHub context?
Author
Owner

My understanding is that the act runner we're using is built for supporting github actions first and gitea/forgejo add variables on top. So, it has worked in testing on local and remote runners.

My understanding is that the act runner we're using is built for supporting github actions first and gitea/forgejo add variables on top. So, it has worked in testing on local and remote runners.
sixsmith marked this conversation as resolved
Member

@Brooke LGTM overall - do you think there is an easy fix to the the registry push issues? If not, I'm fine merging this while we figure that out.

@Brooke LGTM overall - do you think there is an easy fix to the the registry push issues? If not, I'm fine merging this while we figure that out.
Author
Owner

@Brooke LGTM overall - do you think there is an easy fix to the the registry push issues? If not, I'm fine merging this while we figure that out.

Not that I'm aware, but I also didn't independently replicate any push issues, the runner seemed to be able to handle it fine. Unless I'm thinking of something else.

> @Brooke LGTM overall - do you think there is an easy fix to the the registry push issues? If not, I'm fine merging this while we figure that out. Not that I'm aware, but I also didn't independently replicate any push issues, the runner seemed to be able to handle it fine. Unless I'm thinking of something else.
sixsmith marked the pull request as ready for review 2026-08-27 11:36:10 +00:00
sixsmith merged commit d2cb35e5ca into main 2026-08-27 11:36:21 +00:00
Sign in to join this conversation.